feat(hipcub): Add CCCL 3.0.x support (copy) - #9931
Merged
Merged
Conversation
…o ``DeviceSegmentedSort``
…::min and std::max to hip::std
… sort comparator test
…value` in single index iterator
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
spolifroni-amd
approved these changes
Jul 24, 2026
NguyenNhuDi
approved these changes
Jul 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9931 +/- ##
============================================
+ Coverage 69.54% 91.34% +21.80%
============================================
Files 2769 500 -2269
Lines 451674 42012 -409662
Branches 66439 5407 -61032
============================================
- Hits 314101 38374 -275727
+ Misses 116577 3272 -113305
+ Partials 20996 366 -20630
🚀 New features to boost your workflow:
|
Several tests are consistently failing on Windows with gfx1151. Temporarily disable these until we locate the root cause and find a proper fix.
umfranzw
force-pushed
the
users/umfranzw/hipcub_cccl3.0_copy
branch
from
July 25, 2026 12:34
7ae6e35 to
f06b631
Compare
assistant-librarian Bot
pushed a commit
to ROCm/hipCUB
that referenced
this pull request
Jul 25, 2026
feat(hipcub): Add CCCL 3.0.x support (copy) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Note: this is a rocm-libraries-based copy of ROCm/rocm-libraries#4079 in case we need to make immediate changes. Add CCCL 3.0.x support for hipCUB library. Additional updates: fix CUB backend JIRA ID : EXSWSTRHPC-300
assistant-librarian Bot
pushed a commit
to ROCm/rocPRIM
that referenced
this pull request
Jul 25, 2026
feat(hipcub): Add CCCL 3.0.x support (copy) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Note: this is a rocm-libraries-based copy of ROCm/rocm-libraries#4079 in case we need to make immediate changes. Add CCCL 3.0.x support for hipCUB library. Additional updates: fix CUB backend JIRA ID : EXSWSTRHPC-300
assistant-librarian Bot
pushed a commit
to ROCm/rocThrust
that referenced
this pull request
Jul 25, 2026
feat(hipcub): Add CCCL 3.0.x support (copy) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Note: this is a rocm-libraries-based copy of ROCm/rocm-libraries#4079 in case we need to make immediate changes. Add CCCL 3.0.x support for hipCUB library. Additional updates: fix CUB backend JIRA ID : EXSWSTRHPC-300
This was referenced Jul 27, 2026
lamb-j
added a commit
to ROCm/llvm-project
that referenced
this pull request
Jul 27, 2026
## Why `Applications/monte_carlo_pi` was migrated off the CUB-style hipcub iterators that CCCL 3.0 removed (ROCm/rocm-libraries#9931) to the portable `thrust::` iterators — see ROCm/rocm-examples#493. That migration pulls in a rocThrust dependency (`find_package(rocthrust REQUIRED)`), which the SPIRV CI build job doesn't currently install, so the `Test rocm-examples` job would fail at configure with `Could not find rocthrust`. ## What Add a rocThrust checkout + install into the staging tree so the rocm-examples build can find it: - Add `ROCTHRUST_BUILD` env var. - Checkout `ROCm/rocThrust@develop`, configure + install into staging after hipCUB. rocThrust is header-only, so it's a fast configure + install, mirroring the hipCUB step. - Include the build dir in the strip + tar steps. ## Ordering The `Test rocm-examples` job stays red until **both** this and rocm-examples#493 land (either order); then the next `amd-staging` run goes green. The job is informational (not a required check), so this doesn't block merges in the meantime.
lamb-j
added a commit
to ROCm/rocm-examples
that referenced
this pull request
Jul 27, 2026
…493) * fix(monte_carlo_pi): migrate off hipcub iterators removed in CUB 3.0 hipCUB's CCCL 3.0 update (ROCm/rocm-libraries#9931) removed the CUB-style iterator headers (counting/constant/transform/discard) that Applications/monte_carlo_pi included, breaking its build against current hipCUB. Switch to the portable Thrust iterators, which is the replacement CUB 3.0 itself points to. Changes: - main.hip: replace hipcub::CountingInputIterator / TransformInputIterator with thrust::counting_iterator / thrust::make_transform_iterator; drop the unused discard_output_iterator include. hipcub::DeviceReduce::Sum is unchanged and accepts Thrust iterators. - CMakeLists.txt: find + link rocThrust on the AMD path (roc::rocthrust); NVIDIA gets the Thrust headers from the already-required CUDA Toolkit. * Apply suggestion from @idubinov Co-authored-by: idubinov <idubinov@amd.com> --------- Co-authored-by: idubinov <idubinov@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is a rocm-libraries-based copy of #4079 in case we need to make immediate changes.
Add CCCL 3.0.x support for hipCUB library.
Additional updates: fix CUB backend
JIRA ID : EXSWSTRHPC-300