fix: refactoring translations to rely on readalong DOM instead of state #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deltork
force-pushed
the
dev.del/328-translation-tier-issue
branch
from
45c8e32 to
ad9ef75
Compare
Fixed, pushed a work-around for version <1.1 with translation tiers without id |
deltork
force-pushed
the
dev.del/328-translation-tier-issue
branch
2 times, most recently
from
94f0875 to
d52b764
Compare
deltork
force-pushed
the
dev.del/328-translation-tier-issue
branch
from
d52b764 to
9225d2b
Compare
|
@joanise I need translation help |
joanise
reviewed
Sep 11, 2024
Comment on lines
32
to
35
| "edit-layer": "Rename annotation title", | ||
| "delete-layer": "Remove annotation title", | ||
| "save-layer": "Save annotation title", | ||
| "create-layer": "Create an annotation title" |
There was a problem hiding this comment.
These are not intuitive to me. I would change all of them to "annotation layer" instead of "annotation title".
Comment on lines
32
to
35
| "edit-layer": "Renommer le titre de l'annotation", | ||
| "delete-layer": "Supprimer le titre de l'annotation", | ||
| "save-layer": "Enregistrer le titre de l'annotation", | ||
| "create-layer": "Créer un titre d'annotation" |
There was a problem hiding this comment.
And here "la/une couche d'annotation" instead of "le titre".
This is consistent with the translations I did for the tour.
Comment on lines
32
to
35
| "edit-layer": "Cambiar el nombre del título de la anotación", | ||
| "delete-layer": "Eliminar el título de la anotación", | ||
| "save-layer": "Guardar el título de la anotación", | ||
| "create-layer": "Crear un título de anotación" |
There was a problem hiding this comment.
And "la/una capa de anotación".
joanise
approved these changes
Sep 12, 2024
This was referenced Sep 13, 2024
joanise
added a commit
that referenced
this pull request
Oct 16, 2024
*fix: refactoring translations to rely on readalong DOM instead of state (#330) * fix: refactoring translations to rely on readalong DOM instead of state * test: fix test for editing readalong * feat: es and fr translations for layers messages * fix: refine some translations and text strings --------- Co-authored-by: Eric Joanis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Rewrite of the translation tier to accomodate the creation of annotation layers
Fixes?
#328
Feedback sought?
sanity check
Priority?
high
Tests added?
How to test?
test with the following files
ej-fra.readalong,ej-fra-annotated.readalong,ej-fra-translated.readalongfound in packages/web-component/test-data/ej-fraConfidence?
high
Version change?
minor
TODO: