Default subscriber QOS to BestEffort, account for TRANSIENT_LOCAL#991
Merged
Conversation
bjsowa
requested changes
Jan 20, 2025
Member
bjsowa
left a comment
bjsowa
left a comment
There was a problem hiding this comment.
That seems reasonable. Could you please add a parameter for the default subscription reliability policy? That way, it will be easier for me to backport it to Humble.
bjsowa
approved these changes
Feb 26, 2025
bjsowa
pushed a commit
that referenced
this pull request
May 18, 2025
* use permissive QoS to ensure compatibilty with publishers * use RELIABLE qos if publisher found to be TRANSIENT_LOCAL --------- Co-authored-by: William Wedler <wwedler@riseup.net> Co-authored-by: Mike Wake <michael.wake@aosgrp.com.au>
This was referenced May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
Change default subscriber QosProfile from reliability=ReliabilityPolicy.RELIABLE to reliability=ReliabilityPolicy.BEST_EFFORT.
BUT if a publisher is found to have durability = DurabilityPolicy.TRANSIENT_LOCAL, then use reliability=ReliabilityPolicy.RELIABLE
Description
IMO the current "sane" defaults for a subscriber are not great for unreliable links and/or large messages and are not compatible with publisher policy is not yet known.
Relates to #769