-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apcd-cms): core-cms v3.11.0 candidate #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much of this change requires Core-CMS v3.11.0.
19 tasks
This fix: - removes first column border (from core, designer rejected) - stretches table to 100% width (like others)
edmondsgarrett
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking great on QA! Approved.
Cool! I found some things I may do before I merge:
Footnotes |
This was referenced May 25, 2023
Final tasks complete:
I merge. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Overview
Change APCD CMS to rely on upcoming Core-CMS v3.11 code instead of TACC/Core-CMS#567.*
* TACC/Core-CMS#567 was v3.9 + 25 commits of v3.10.
Related
Changes
UI
Code
conflicts-with-core
css files to deal with apcd still being both a bit ahead and behind coreTesting
Deployed to https://apcd-qa.tacc.utexas.edu/ on 2023-05-21.
UI
Register
Submissions
Administration
Help
Notes
Known Issues
c-button c-button--primary
.