feat(apcd-cms): core-cms v3.11.0 candidate

[wesleyboar]

Status

Overview

Change APCD CMS to rely on upcoming Core-CMS v3.11 code instead of TACC/Core-CMS#567.*

^{* TACC/Core-CMS#567 was v3.9 + 25 commits of v3.10.}

1. Finally brings belated Core-Styles to APCD.
2. Tests v3.11 on the CMS most cumbersome to upgrade.
3. Removes cruft and duplicate CSS.

Related

• requires https://github.com/TACC/Core-CMS/releases/tag/v3.11.0-beta.2
• is not coupled with fix(apcd-cms): add+load css not in core-styles v2 ⏸️ #141

Changes

UI

• new table styles
• fixed link hover state (border was dashed and too close to text)
• new accent color (purple, matches portal)

Code

• changed core cms image
• added load of new apcd table and modal stylesheets
• removed load of unused form stylesheets (now available from core)
• removed stylesheets, or code from stylesheets, whose code is now in apcd table and modal stylesheets
  • per-page css is retained in per-page stylesheets
• changed pagination to load from core-styles v0.13 (instead of v0.10)
• added conflicts-with-core css files to deal with apcd still being both a bit ahead and behind core
• removed most table desktop styles

Testing

Deployed to https://apcd-qa.tacc.utexas.edu/ on 2023-05-21.

1. Compare all pages to pre-prod before deploy of new CMS version.

UI

Register

	before	after
Request to Submit

Submissions

	before	after
List Submissions
Request Exception
Request Exception Form
Request Extension
Request Extension Form

Administration

	before	after
List Submissions
List Extension Requests
List Exception Requests
List Users
List Registrations

Help

	before	after
Reference

Notes

Known Issues

1. https://apcd-qa.tacc.utexas.edu/submissions/exception/ buttons do not have hover state.
   • Pre-existing bug.
   • Caused by APCD markup not using c-button c-button--primary.
2. Font that is regular weight and italic style is too thick.
   • Pre-existing bug which now occurs in modal forms (because styling is now consistent).
   • See TACC/Core-CMS#638 "Known Issues" № 6.
3. Accent color has changed from blue to purple.
   • Not a bug.
   • See TACC/Core-CMS#638 "Known Issues" № 3.
4. Pagination styles are wrong on Review Extensions and Review Exceptions pages.
   • Pre-existing bug.
   • Reported in WP-150.

[edmondsgarrett]

Things are looking great on QA! Approved.

[wesleyboar]

Cool!

I found some things I may do before I merge:

• test https://apcd-qa.tacc.utexas.edu/submissions/threshold-exception/ ¹
• test https://apcd-qa.tacc.utexas.edu/submissions/extension-request/ ¹
• maybe change purple back to blue (for Core-CMS v3.11)

Footnotes

1. Requires I be in the database. ↩ ↩²

[wesleyboar]

Final tasks complete:

• I tested https://apcd-qa.tacc.utexas.edu/submissions/threshold-exception/.
• I tested https://apcd-qa.tacc.utexas.edu/submissions/extension-request/.
• Only accent color differs. Fix can come in https://github.com/TACC/Core-CMS/releases/tag/v3.11.0-beta.3.
• This PR is not coupled to fix(apcd-cms): add+load css not in core-styles v2 ⏸️ #141. That PR can wait.

I merge.