Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test vector changes #152

Merged
merged 8 commits into from
Jan 25, 2024
Merged

test vector changes #152

merged 8 commits into from
Jan 25, 2024

Conversation

jiyoontbd
Copy link
Contributor

@jiyoontbd jiyoontbd commented Jan 22, 2024

Summary

generate-test-vectors (p)npm script now overwrites the generated vectors into test vector json files inside the tbdex submodue folder.
Part of an effort to break apart #126 into smaller ones. Related to #122

Copy link

changeset-bot bot commented Jan 22, 2024

⚠️ No Changeset found

Latest commit: 051fa0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jiyoontbd jiyoontbd mentioned this pull request Jan 23, 2024
const offering = Offering.create({
metadata : { from: did.did },
data : DevTools.createOfferingData()
data : {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistermoe are we cool to go back to using DevTools since we're keeping that class?

Copy link
Contributor

github-actions bot commented Jan 23, 2024

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2024-01-24T21:49:08Z 051fa0d

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Merging #152 (051fa0d) into main (738cb1f) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          18       18           
  Lines         981      981           
  Branches       82       82           
=======================================
  Hits          732      732           
  Misses        249      249           
Components Coverage Δ
protocol ∅ <ø> (∅)
http-client 82.02% <ø> (ø)
http-server 68.73% <ø> (ø)

@jiyoontbd jiyoontbd linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link
Contributor

@kirahsapong kirahsapong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jiyoontbd jiyoontbd merged commit 72fa522 into main Jan 25, 2024
17 checks passed
@jiyoontbd jiyoontbd deleted the test-vector-helpers-refactor branch January 25, 2024 02:22
jiyoontbd added a commit to TBD54566975/tbdex that referenced this pull request Jan 25, 2024
…229)

* Ran generate-test-vectors in tbdex-js PR [#152](TBD54566975/tbdex-js#152) to update test vectors

* regenerated test vectors

* fixing parse offering to use a real did when creating offering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[http-client] refactor request token to be a JWT
3 participants