Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract wheel encoder to separate thread for faster sampling #116

Merged
merged 14 commits into from
Jun 1, 2024
Merged

Extract wheel encoder to separate thread for faster sampling #116

merged 14 commits into from
Jun 1, 2024

Conversation

ryescholin
Copy link
Member

@ryescholin ryescholin commented Jun 1, 2024 •
edited by taesungh
Loading

Create separate task thread for sampling wheel encoder. Resolves #108.

vrushang1234
vrushang1234 approved these changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@vrushang1234 vrushang1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

taesungh
taesungh reviewed Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Some notes along with a concern about when mutex becomes unlocked.

pod-operation/src/state_machine.rs Show resolved Hide resolved
pod-operation/src/state_machine.rs Show resolved Hide resolved
pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
@ryescholin ryescholin linked an issue Jun 1, 2024 that may be closed by this pull request
Extract wheel encoder to separate thread for faster sampling #108
Closed
taesungh
taesungh approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, note: still need to actually handle the fault so we don't have an incident like last year.

@ryescholin ryescholin merged commit 9cc31bd into main Jun 1, 2024
2 checks passed
@taesungh taesungh mentioned this pull request Jun 1, 2024
Open
@taesungh taesungh deleted the wheel_encoder_thread branch June 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrushang1234 vrushang1234 vrushang1234 approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract wheel encoder to separate thread for faster sampling
3 participants
@ryescholin @taesungh @vrushang1234