Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: more accurate local time sync with server time #3206

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

fix: more accurate local time sync with server time #3206

wants to merge 6 commits into from
+36 −25

Conversation

NoelStephensUnity
Copy link
Collaborator

User Contribution (@BenHamrick) (#3028)

This PR changes the NetworkTimeSystem.Sync method to use half RTT to calculate the desired local time offset as opposed to the full RTT.

Changelog

  • Changed: NetworkTimeSystem.Sync method to use half RTT to calculate the desired local time offset as opposed to the full RTT.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

BenHamrick and others added 4 commits January 15, 2025 13:53
@BenHamrick @NoelStephensUnity
get a more accurate local time by using half the RTT.
24de284
@NoelStephensUnity
update
b9a9da8 
adding change log entry.
@NoelStephensUnity
updarte
4945e3d 
adding PR number to entry.
@NoelStephensUnity
test
07575a5 
Adjusting ClientNetworkTimeSystemTests to account for half RTT adjustment applied in this PR.
@NoelStephensUnity
style
a04a177 
Adding a comment about the change
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review January 16, 2025 01:59
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner January 16, 2025 01:59
@michalChrobot michalChrobot added the stat:awaiting triage Status - Awaiting triage from the Netcode team. label Jan 16, 2025
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jan 19, 2025
Open
@NoelStephensUnity
style
5f12a96 
removing whitespace after comment
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jan 19, 2025
Closed
@michalChrobot michalChrobot added port:2.x-needed This issue needs to be ported to 2.X branch and removed up-port-for-2.0.0-required labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmandM EmandM Awaiting requested review from EmandM

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
port:2.x-needed This issue needs to be ported to 2.X branch stat:awaiting triage Status - Awaiting triage from the Netcode team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoelStephensUnity @michalChrobot @BenHamrick