Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tf_prefix from ur_control.launch.py #1020

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Remove tf_prefix from ur_control.launch.py #1020

merged 1 commit into from
Jun 17, 2024

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Jun 13, 2024

This is now part of ur_rsp.launch.py

@fmauch fmauch requested a review from VinDp June 13, 2024 09:10
Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, looks good to me.

This is now part of ur_rsp.launch.py
@fmauch fmauch merged commit 0e410cb into main Jun 17, 2024
11 checks passed
@fmauch fmauch deleted the fmauch-patch-1 branch June 17, 2024 09:23
fmauch added a commit to fmauch/Universal_Robots_ROS2_Driver that referenced this pull request Jun 19, 2024
)"

tf_prefix is used as a substitution argument inside the controllers.yaml

Therefore, it needs to be specified as an argument for the ur_conttrol.launch.py file
VinDp pushed a commit to fmauch/Universal_Robots_ROS2_Driver that referenced this pull request Jun 19, 2024
)"

tf_prefix is used as a substitution argument inside the controllers.yaml

Therefore, it needs to be specified as an argument for the ur_conttrol.launch.py file
VinDp pushed a commit that referenced this pull request Jun 19, 2024
* Make test without a tf_prefix actually not specify the tf_prefix to the launchfile

* Revert "Remove tf_prefix from ur_control.launch.py (#1020)"

tf_prefix is used as a substitution argument inside the controllers.yaml

Therefore, it needs to be specified as an argument for the ur_conttrol.launch.py file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants