Switch to "use_fake_hardware" for UR20 #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmauch
approved these changes
Apr 9, 2024
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
On Humble fake_hardware is still used. (cherry picked from commit f6235d3)
fmauch
pushed a commit
that referenced
this pull request
Apr 9, 2024
On Humble fake_hardware is still used. (cherry picked from commit f6235d3) Co-authored-by: Vincenzo Di Pentima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the UR20 is the only one using "use_mock_hardware" and since the description pkg for humble still has "use_fake_hardware", it doesn't work launching it with the mock_hardware option.
Maybe it's better to have fake_hardware also for the UR20 and in the future switch all the models together when fake_hardware can't be used anymore.
Also, the same goes for iron, so if this makes sense I will open a PR for the iron branch as well.