micro-fix: GitGuardian alert: derive credential IDs from fixtures instead of hardcoding#5683
Open
Taimoor2500 wants to merge 1 commit intoaden-hive:mainfrom
Open
micro-fix: GitGuardian alert: derive credential IDs from fixtures instead of hardcoding#5683Taimoor2500 wants to merge 1 commit intoaden-hive:mainfrom
Taimoor2500 wants to merge 1 commit intoaden-hive:mainfrom
Conversation
…e for improved clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When forking the repository, GitGuardian reported hardcoded credential-like strings in the Aden sync tests. This PR removes those hardcoded values and derives them from fixtures instead.
Problem
In test_sync_all, the credential ID "aHVic3BvdDp0ZXN0OjEzNjExOjExNTI1" was hardcoded in both the mock data and the assertion. GitGuardian flagged this as a potential secret.
Solution
Use aden_response.integration_id as the single source of truth for the credential ID. The mock and assertion now reference this value instead of repeating the string. Behavior is unchanged; only the way the ID is obtained is different.
Changes
test_sync_all: Replace hardcoded credential ID with aden_response.integration_id in both the mock and the assertion.