Skip to content

micro-fix: GitGuardian alert: derive credential IDs from fixtures instead of hardcoding #5683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Taimoor2500 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

micro-fix: GitGuardian alert: derive credential IDs from fixtures instead of hardcoding #5683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/framework/credentials/aden/tests/test_aden_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,10 @@ def test_fetch_from_aden_not_found(self, provider, mock_client):

def test_sync_all(self, provider, mock_client, aden_response):
"""Test syncing all credentials."""
active_id = aden_response.integration_id
mock_client.list_integrations.return_value = [
AdenIntegrationInfo(
integration_id="aHVic3BvdDp0ZXN0OjEzNjExOjExNTI1",
integration_id=active_id,
provider="hubspot",
alias="My HubSpot",
status="active",
Expand All @@ -411,7 +412,7 @@ def test_sync_all(self, provider, mock_client, aden_response):
synced = provider.sync_all(store)

assert synced == 1 # Only active one was synced
assert store.get_credential("aHVic3BvdDp0ZXN0OjEzNjExOjExNTI1") is not None
assert store.get_credential(active_id) is not None

def test_validate_via_aden(self, provider, mock_client):
"""Test validation via Aden introspection."""
Expand Down
Loading