Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Unit testing revamp part 4: clustering #1877

Merged
merged 25 commits into from
Sep 18, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

Follows on from #1875, part of AEP 05.

  • Removes the current generic clustering testing and deep learning clusterer tests.
  • Replaces them with a yield function in the new testing framework.

@aeon-actions-bot aeon-actions-bot bot added the maintenance Continuous integration, unit testing & package distribution label Jul 31, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
This PR changes too many different packages (>3) for automatic addition of labels, please manually add package labels if relevant.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

…lustering-testing

# Conflicts:
#	aeon/base/tests/test_base_collection.py
#	aeon/testing/estimator_checking/_yield_estimator_checks.py
#	aeon/testing/test_all_estimators.py
#	aeon/testing/tests/test_all_estimators.py
#	aeon/testing/tests/test_testing_data.py
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review August 15, 2024 13:12
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatthewMiddlehurst MatthewMiddlehurst merged commit c6dfffa into main Sep 18, 2024
14 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/clustering-testing branch September 18, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants