Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing of parsed frames #158

Merged
merged 6 commits into from
May 22, 2024
Merged

Fix processing of parsed frames #158

merged 6 commits into from
May 22, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented May 21, 2024

Completes #150 and provides the last necessary ingredients for #148.

@diegoferigo diegoferigo force-pushed the fix_frame_processing branch 2 times, most recently from a9526be to a72fe5f Compare May 21, 2024 17:09
@diegoferigo diegoferigo marked this pull request as ready for review May 21, 2024 17:11
Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Diego! LGTM, I just left some minor comments

src/jaxsim/parsers/kinematic_graph.py Outdated Show resolved Hide resolved
src/jaxsim/parsers/kinematic_graph.py Outdated Show resolved Hide resolved
src/jaxsim/parsers/kinematic_graph.py Show resolved Hide resolved
src/jaxsim/parsers/descriptions/model.py Outdated Show resolved Hide resolved
Co-authored-by: Filippo Luca Ferretti <[email protected]>
@diegoferigo diegoferigo merged commit 7cfca20 into main May 22, 2024
29 checks passed
@diegoferigo diegoferigo deleted the fix_frame_processing branch May 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants