Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes for the upcoming release #173

Merged
merged 26 commits into from
Jun 12, 2024
Merged

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Jun 11, 2024

Minor changes that were sitting in my local git repository.

@flferretti feel free to push similar changes, if you have any.


馃摎 Documentation preview 馃摎: https://jaxsim--173.org.readthedocs.build//173/

@diegoferigo diegoferigo self-assigned this Jun 11, 2024
@diegoferigo diegoferigo force-pushed the minor_changes_for_new_release branch 3 times, most recently from f58169f to 515477d Compare June 11, 2024 09:22
@diegoferigo diegoferigo force-pushed the minor_changes_for_new_release branch from c90bcca to bf9d7a2 Compare June 12, 2024 14:55
@diegoferigo
Copy link
Member Author

diegoferigo commented Jun 12, 2024

I finally managed to debug the problem on the new check on frame transforms, it has been quite hairy. It turned out that we need to make also JaxSimModel.description hashable (before its hash was disabled). Now things should work fine.

@flferretti as soon as CI turns green, I'm ready to merge.

Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@diegoferigo diegoferigo merged commit e74e24b into main Jun 12, 2024
29 checks passed
@diegoferigo diegoferigo deleted the minor_changes_for_new_release branch June 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants