fix(ui): initialize state selectively to prevent background task conflicts#2773
Merged
tusharmath merged 3 commits intomainfrom Apr 1, 2026
Merged
fix(ui): initialize state selectively to prevent background task conflicts#2773tusharmath merged 3 commits intomainfrom
tusharmath merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix "JoinHandle polled after completion" panics caused by background tasks spawned during
forge inforacing with process exit.Context
When running
forge info, the handler was callingon_new()to initialize the model/agent state. However,on_new()also internally invokeshydrate_caches(), which spawns fire-and-forget background tasks. Becauseforge infoexits quickly after printing output, these background tasks would still be running (or just completing) as the process terminated, triggeringJoinHandle polled after completionpanics in the async runtime.The
infocommand only needs agent/provider/model resolution — it has no use for the cache hydration side effects.Changes
on_new()call withinit_state(false)in theTopLevelCommand::Infohandlerinit_state(false)performs only the necessary state initialization without spawning background cache hydration tasksTesting
Links
UI::on_new()/UI::hydrate_caches()