Do not clean past enqueued snapshot request in AccountsBackgroundService#6437
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6437 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 848 848
Lines 379479 379518 +39
=======================================
+ Hits 314303 314367 +64
+ Misses 65176 65151 -25 🚀 New features to boost your workflow:
|
| // We reuse `get_next_snapshot_request()` here, since it already implements all the logic | ||
| // for getting the highest priority request, *AND* we leverage its test coverage. | ||
| // Additionally, since `get_next_snapshot_request()` drops old requests, we might get to | ||
| // proactively clean up old banks earlier as well! |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
5 participants
Problem
Please see #6295.
Summary of Changes
Do not clean past enqueued snapshot request.
Fixes #6295
Note, needs to be backported to v2.3.