Add error-prone.picnic.tech featuring RedundantStringConversion
#20688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Pankraz76
changed the title
error-prone.picnic.tech featuring RedundantStringConversionerror-prone.picnic.tech featuring RedundantStringConversion
Pankraz76
force-pushed
the
fix-RedundantStringConversion
branch
from
537bd16 to
9ffbf4d
Compare
Pankraz76
changed the title
error-prone.picnic.tech featuring RedundantStringConversionerror-prone.picnic.tech featuring RedundantStringConversion
Pankraz76
force-pushed
the
fix-RedundantStringConversion
branch
2 times, most recently
from
a743545 to
d8d9605
Compare
Pankraz76
force-pushed
the
fix-RedundantStringConversion
branch
from
d8d9605 to
1853449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello friends,
I'm reaching out to propose we enhance our static code analysis implementation by leveraging Spotless to automate Checkstyle formatting. This approach is gaining industry traction, with Keycloak currently evaluating a similar integration as referenced below.
By adopting this proven methodology, we can significantly improve code quality and developer experience. The benefits include:
Having successfully implemented this pattern across multiple projects, I'd be happy to contribute to this initiative for Kafka. We can assess various implementation strategies to find the optimal approach for our specific needs.
For reference, here are several successful implementations demonstrating the tangible benefits:
UpgradeToJava17diffplug/spotless#2636tech.picnic.errorprone.refasterrulesdiffplug/spotless#2641error-prone.picnic.techfeaturingRedundantStringConversionjunit-team/junit-framework#5006LexicographicalAnnotationListingcheckstyle/checkstyle#17892JavaRecipeBestPracticescheckstyle/checkstyle#17806rewritesupport forerrorprone.refasterrules#20219I'm available to discuss this further and help drive this quality improvement forward.
Best regard
Vincent