Skip to content

Remove dependency from "bevy_platform/web" to "bevy_platform/std" #22184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kpreid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dependency from "bevy_platform/web" to "bevy_platform/std" #22184

kpreid wants to merge 1 commit into from

Conversation

@kpreid
Copy link
Contributor

@kpreid kpreid commented Dec 18, 2025

Objective

Fixes #22168.

Solution

Remove dependency from "bevy_platform/web" to "bevy_platform/std", partially reverting #20369.

This PR was made per @alice-i-cecile 's suggestion #22168 (comment). I am not familiar enough with Bevy internal dependencies to know if this is a wise change.

Testing

  • Manually tested that the no_std build described in the issue succeeds.
  • Added a regression test in CI.
  • Did not test whether this has any negative effects on actual web builds.

@kpreid
Remove dependency from "bevy_platform/web" to "bevy_platform/std".
11b526f 
This allows the “web” feature to be enabled without breaking the
build on non-web `no_std` targets. See
<bevyengine#22168>.
@kpreid kpreid mentioned this pull request Dec 18, 2025
Open
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior O-Web Specific to web (WASM) builds D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Needs-Testing Testing must be done before this is safe to merge P-Regression Functionality that used to work but no longer does. Add a test for this! A-Utils Utility functions and types labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NthTensor NthTensor Awaiting requested review from NthTensor

Assignees

No one assigned

Labels

A-Utils Utility functions and types C-Bug An unexpected or incorrect behavior D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes O-Web Specific to web (WASM) builds P-Regression Functionality that used to work but no longer does. Add a test for this! S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Needs-Testing Testing must be done before this is safe to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

no_std regression: is features = ["web"] supposed to affect non-web targets?

2 participants

@kpreid @alice-i-cecile