Skip to content

Remove dependency from "bevy_platform/web" to "bevy_platform/std" #22184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpreid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dependency from "bevy_platform/web" to "bevy_platform/std" #22184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,11 @@ jobs:
uses: ./.github/actions/install-linux-deps
- name: Check Compile
run: cargo check -p bevy --no-default-features --features default_no_std --target x86_64-unknown-none
# Check for regression in "web" feature breaking no_std builds.
# This is not a separate CI job because the added feature should mostly have no effect
# and be able to reuse the prior build.
- name: Check Compile with --features=web
run: cargo check -p bevy --no-default-features --features default_no_std,web --target x86_64-unknown-none

check-compiles-no-std-portable-atomic:
runs-on: ubuntu-latest
Expand Down
4 changes: 1 addition & 3 deletions crates/bevy_platform/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,8 @@ alloc = ["portable-atomic-util/alloc", "dep:hashbrown", "serde?/alloc"]
## on all platforms, including `no_std`.
critical-section = ["dep:critical-section", "portable-atomic/critical-section"]

## Enables use of browser APIs.
## Note this is currently only applicable on `wasm32` architectures.
## Enables use of browser APIs if the build is a `wasm32` target.
web = [
"std",
"dep:web-time",
"dep:wasm-bindgen-futures",
"dep:wasm-bindgen",
Expand Down