MeshAllocator: Take padding elements into account in the MeshBufferSlice's range #22187
+18
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When using
Indices::U16(or custom vertex attributes that have padding elements), theMeshAllocator::mesh_index_slicedoesn't take padding elems into account.For example, run the
linesexample with the following change:The index count of LineStrip should be 3 with 1 padding in the slab, which should be 3 vertexes but RenderDoc shows 4 vertexes:


Solution
Fix MeshAllocator by taking padding elements into account and subtract it from the end of the range.
Testing
Run

linesexample with above patch, the index count is correct: