Remove the need to import SpawnRelated to use related! macro
#22331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDoot
added
D-Trivial
alice-i-cecile
approved these changes
Jan 1, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2026
…elated!` (#22384) # Objective Same deal as #22331 but for the `children!` macro. ## Solution Make `children!` delegate to `related!` in order to: - Remove the need to import `SpawnRelated` when using it. - Reduce code duplication. - Make `children!` look less special-cased (it's just `related!` with a bevy-provided relation type). ## Testing Removed imports of `SpawnRelated` where it's no longer needed, to prove it works.
cart
pushed a commit
that referenced
this pull request
Jan 8, 2026
…elated!` (#22384) # Objective Same deal as #22331 but for the `children!` macro. ## Solution Make `children!` delegate to `related!` in order to: - Remove the need to import `SpawnRelated` when using it. - Reduce code duplication. - Make `children!` look less special-cased (it's just `related!` with a bevy-provided relation type). ## Testing Removed imports of `SpawnRelated` where it's no longer needed, to prove it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently in order to use
related!macro you have to additionally importSpawnRelated. We should be able to avoid that.Solution
Added an
as SpawnRelatedtypecast in the macro expansion.Testing
Removed the import from the macro's doctest to prove that it works.