Skip to content

Fix panic in mesh picking when a mesh is RENDER_WORLD only #22356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 1 commit into from
Jan 5, 2026
+9 −4
Merged

Fix panic in mesh picking when a mesh is RENDER_WORLD only #22356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions crates/bevy_picking/src/mesh_picking/ray_cast/intersections.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,26 @@ pub(super) fn ray_intersection_over_mesh(
return None; // ray_mesh_intersection assumes vertices are laid out in a triangle list
}
// Vertex positions are required
let positions = mesh.attribute(Mesh::ATTRIBUTE_POSITION)?.as_float3()?;
let positions = mesh
.try_attribute(Mesh::ATTRIBUTE_POSITION)
.ok()?
.as_float3()?;

// Normals are optional
let normals = mesh
.attribute(Mesh::ATTRIBUTE_NORMAL)
.try_attribute(Mesh::ATTRIBUTE_NORMAL)
.ok()
.and_then(|normal_values| normal_values.as_float3());

let uvs = mesh
.attribute(Mesh::ATTRIBUTE_UV_0)
.try_attribute(Mesh::ATTRIBUTE_UV_0)
.ok()
.and_then(|uvs| match uvs {
VertexAttributeValues::Float32x2(uvs) => Some(uvs.as_slice()),
_ => None,
});

match mesh.indices() {
match mesh.try_indices().ok() {
Some(Indices::U16(indices)) => {
ray_mesh_intersection(ray, transform, positions, normals, Some(indices), uvs, cull)
}
Expand Down