Solari: Improved mirror denoising #22459
Open
+178
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
commented
Jan 9, 2026
| let specular_motion_vector = calculate_motion_vector(virtual_position, virtual_previous_frame_position); | ||
|
|
||
| let F0 = calculate_F0(ray_hit.material.base_color, ray_hit.material.metallic, ray_hit.material.reflectance); | ||
| let wo = normalize(view.world_position - virtual_position); |
Contributor
Author
There was a problem hiding this comment.
Not entirely sure about calculating wo like this for env_brdf_approx2, but it makes sense to me. Let me know what reviewers think.
JMS55
added
A-Rendering
…nts WC from showing up in reflections when you're really close to something)
JMS55
commented
Jan 9, 2026
Contributor
Author
|
This PR somehow broke Solari when compiling without DLSS. I need to figure out why. |
| let wo = normalize(view.world_position - virtual_position); | ||
| let virtual_normal = normalize(mirror_rotations * ray_hit.world_normal); | ||
|
|
||
| textureStore(specular_motion_vectors, pixel_id, vec4(specular_motion_vector, vec2(0.0))); |
Contributor
There was a problem hiding this comment.
Are specular motion vectors meant to be used with PSR?
Contributor
Author
There was a problem hiding this comment.
I think so? It's a little hard to find literature on it.
Contributor
There was a problem hiding this comment.
Is there a noticeable difference in image quality in motion when they're set vs just defaulted to 0?
Contributor
Author
There was a problem hiding this comment.
I tested it, and I don't think so. Maybe it matters for more complex situations? Idk really.
alice-i-cecile
added
the
S-Needs-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Showcase
Before
After
