[Types] spring-split - #7290
Closed
keithharvey wants to merge 4 commits into
Closed
Conversation
Contributor
Integration Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 5873f39. ♻️ This comment has been updated with latest results. |
keithharvey
force-pushed
the
mig-spring-split
branch
from
March 31, 2026 04:53
df25858 to
ffdb36d
Compare
This was referenced Mar 31, 2026
Closed
Closed
keithharvey
force-pushed
the
mig-spring-split
branch
from
March 31, 2026 04:55
ffdb36d to
54d4035
Compare
This was referenced Mar 31, 2026
Closed
keithharvey
force-pushed
the
mig-spring-split
branch
11 times, most recently
from
April 4, 2026 16:51
50f8cee to
409378f
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 11, 2026 20:29
409378f to
51c2276
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
8 times, most recently
from
April 12, 2026 22:36
4a8cc5a to
ba065ae
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 29, 2026 20:17
c394210 to
8103807
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 30, 2026 03:02
8103807 to
19a10c8
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 30, 2026 03:14
19a10c8 to
d4a13ec
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 30, 2026 03:34
d4a13ec to
96ce29e
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 30, 2026 03:58
96ce29e to
2979d7f
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 30, 2026 04:55
2979d7f to
67f67c0
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 30, 2026 06:19
67f67c0 to
3be4741
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
April 30, 2026 07:27
3be4741 to
ac04361
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
June 9, 2026 08:55
ac04361 to
09b1cd6
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
June 10, 2026 00:51
09b1cd6 to
807435c
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
June 10, 2026 03:09
807435c to
348a1a4
Compare
keithharvey
force-pushed
the
mig-spring-split
branch
from
June 10, 2026 18:38
348a1a4 to
989382d
Compare
…ring
Renames spec/builders/{spring->engine}_{,un}synced_builder.lua + their
builder_specs, Builders.Spring->Builders.EngineSynced,
Builders.SpringUnsynced->Builders.EngineUnsynced, @Class names, and all
call sites. The renamed builders own every Engine-related test edit so no
two prereqs touch one file:
- engine_synced_builder.lua: gamedata/system.lua defs mock aliases
Engine.{Shared,Synced,Unsynced} + BAR to the _G.Spring/_G.BAR mocks
- engine_unsynced_builder.lua: widget sandbox gets env.Engine; capture
spies install on Engine.Shared.*
Prefix branch -> lands in fmt once, every leaf+mig inherits it.
- spec_helper.lua: Engine.{Synced,Unsynced,Shared} proxy to the current
_G.Spring mock (metatable, resolved per access) so global/gadget code and
tests that swap _G.Spring resolve correctly.
- spring_unsynced_builder.lua: inject env.Engine into the widget sandbox
(widgets call Engine.Shared.X after spring-split); capture spies install on
Engine.Shared.* to match.
Collaborator
Author
|
Closing: the spring-split transform was dropped from the fmt-mig pipeline (BAR-Devtools d12b5b9) — it needs the generated recoil-lua-library and was holding up a clean merge. The migration stack proceeds without it; see the tracking issue #7408 for the current topology. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of BAR type-error cleanup. Rebuilds idempotently from
masterviajust bar::fmt-mig-generate.What it does: Splits the monolithic
Springtable intoEngine.Synced/Engine.Unsynced/Engine.Shared, rewriting eachSpring.Xto the bucket that actually declaresXper the generated API stubs — so synced/unsynced-only calls type-check in the right context.See RecoilEngine#2799 for the Engine.Synced/Engine.Unsynced/Engine.Shared type split on the engine side.
Branch Topology
All branches in the BAR type-error cleanup stack. Regenerated deterministically by
just bar::fmt-mig-generate. Generated 2026-06-11 10:24:54 UTC.Leaves — each targets
master, mergeable independently:styluabar-lua-codemod bracket-to-dotbar-lua-codemod rename-aliasesbar-lua-codemod detach-bar-modulesbar-lua-codemod i18n-kikitobar-lua-codemod spring-split<hand curated><hand curated>Rollups — composite branches stacking the leaves and (for
fmt-llm) the env + LLM layers:master