Skip to content

[Types] rename-aliases - #7288

Closed
keithharvey wants to merge 1 commit into
beyond-all-reason:fmtfrom
keithharvey:mig-rename-aliases
Closed

[Types] rename-aliases#7288
keithharvey wants to merge 1 commit into
beyond-all-reason:fmtfrom
keithharvey:mig-rename-aliases

Conversation

@keithharvey

@keithharvey keithharvey commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

Warning

Superseded — this PR was an earlier mint of the stack. The type-error cleanup
now lands via the current stack tip fmt-llm #8398.
This slice's current counterpart is #8402.
Kept closed for review history; nothing here merges.

Part of BAR type-error cleanup. Rebuilds idempotently from master via just bar::migrate::stylua-cleanup-generate.

What it does: Renames deprecated Spring method aliases to their canonical names (e.g. Spring.GetMyTeamIDSpring.GetLocalTeamID) so call sites line up with the names the engine type stubs declare.

# rename-aliases -- deprecated aliases, e.g. GetMyTeamID -> GetLocalTeamID
bar-lua-codemod rename-aliases --path "$BAR_DIR" --exclude common/luaUtilities --exclude .lux --exclude recoil-lua-library --exclude mapgenerator

Branch Topology

All branches in the BAR type-error cleanup stack — see Bulk Migrations for the migration log and how to run just bar::migrate::stylua-cleanup. Regenerated deterministically by just bar::migrate::stylua-cleanup-generate. Generated 2026-07-22 19:44:37 UTC.

Leaves — each isolates one transform's diff vs fmt:

Branch Command Diff vs parent Units
fmt stylua 1425 files, +196955 −195449 ✅ pass
mig-bracket bar-lua-codemod bracket-to-dot 351 files, +7779 −7779 ✅ pass
👉 mig-rename-aliases — you are here bar-lua-codemod rename-aliases 177 files, +376 −376 ✅ pass
mig-detach-bar-modules bar-lua-codemod detach-bar-modules 181 files, +1702 −1573 ✅ pass
mig-integration-tests <hand curated> 20 files, +134 −81 ✅ pass
mig-busted-types <hand curated> 12 files, +1501 −0 ✅ pass

Rollups — composite branches stacking the leaves and (for fmt-llm) the env + LLM layers:

Branch Diff vs master Diff vs parent Units
mig 1449 files, +201211 −198022 528 files, +11446 −9763 ✅ pass
fmt-llm-source 1454 files, +201680 −198185 61 files, +523 −217 ✅ pass
fmt-llm 1456 files, +201733 −198206 32 files, +70 −38 ✅ pass

@github-actions

github-actions Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

14 tests   6 ✅  3s ⏱️
 1 suites  8 💤
 1 files    0 ❌

Results for commit ad3c7c2.

♻️ This comment has been updated with latest results.

@keithharvey
keithharvey force-pushed the mig-rename-aliases branch 4 times, most recently from c6b541e to 9fa59d3 Compare April 1, 2026 21:46
@keithharvey
keithharvey marked this pull request as ready for review April 1, 2026 21:51
@keithharvey
keithharvey force-pushed the mig-rename-aliases branch 3 times, most recently from 60b899e to 0b4b49b Compare April 3, 2026 19:27
@keithharvey
keithharvey marked this pull request as draft April 3, 2026 19:31
@keithharvey
keithharvey force-pushed the mig-rename-aliases branch 4 times, most recently from 4db1750 to 3ed3c13 Compare April 4, 2026 16:51
@keithharvey
keithharvey force-pushed the mig-rename-aliases branch 6 times, most recently from c413421 to 815c749 Compare April 12, 2026 16:42
@keithharvey
keithharvey force-pushed the mig-rename-aliases branch from e724011 to 5a6dbfd Compare June 9, 2026 08:55
@keithharvey

Copy link
Copy Markdown
Collaborator Author

Superseded by #8402 — recreated with its head on beyond-all-reason instead of the fork; the whole migration stack now lives same-repo. Branch content is identical; review history stays readable here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant