[Types] detach-bar-modules

[keithharvey]

Warning

Superseded — this PR was an earlier mint of the stack. The type-error cleanup
now lands via the current stack tip fmt-llm #8398.
This slice's current counterpart is #8403.
Kept closed for review history; nothing here merges.

Part of BAR type-error cleanup. Rebuilds idempotently from master via just bar::migrate::stylua-cleanup-generate.

What it does: Moves BAR-added helpers off the Spring table into a BAR namespace — Spring.I18N → BAR.I18N, plus BAR.Utilities, BAR.Debug, BAR.Lava, and BAR.GetModOptionsCopy — since they aren't engine API and otherwise break type-checking against the Spring stubs.

# detach-bar-modules -- moves I18N, Utilities, Debug, Lava, GetModOptionsCopy off the Spring table
bar-lua-codemod detach-bar-modules --path "$BAR_DIR" --exclude common/luaUtilities --exclude .lux --exclude recoil-lua-library --exclude mapgenerator

The detach-bar-modules-env prereq exposes BAR to the widget/gadget sandbox (luarules/system.lua, luaui/system.lua), bootstraps BAR = BAR or {} in init.lua/springOverrides.lua before the detached defs, adds the consolidated types/BAR.lua stub, and lists BAR as a global in .emmyrc.json. Cherry-picked on top of fmt before the codemod runs.

Branch Topology

All branches in the BAR type-error cleanup stack — see Bulk Migrations for the migration log and how to run just bar::migrate::stylua-cleanup. Regenerated deterministically by just bar::migrate::stylua-cleanup-generate. Generated 2026-07-22 19:44:39 UTC.

Leaves — each isolates one transform's diff vs fmt:

Branch	Command	Diff vs parent	Units
fmt	stylua	1425 files, +196955 −195449	✅ pass
mig-bracket	bar-lua-codemod bracket-to-dot	351 files, +7779 −7779	✅ pass
mig-rename-aliases	bar-lua-codemod rename-aliases	177 files, +376 −376	✅ pass
👉 mig-detach-bar-modules — you are here	bar-lua-codemod detach-bar-modules	181 files, +1702 −1573	✅ pass
mig-integration-tests	<hand curated>	20 files, +134 −81	✅ pass
mig-busted-types	<hand curated>	12 files, +1501 −0	✅ pass

Rollups — composite branches stacking the leaves and (for fmt-llm) the env + LLM layers:

Branch	Diff vs master	Diff vs parent	Units
mig	1449 files, +201211 −198022	528 files, +11446 −9763	✅ pass
fmt-llm-source	1454 files, +201680 −198185	61 files, +523 −217	✅ pass
fmt-llm	1456 files, +201733 −198206	32 files, +70 −38	✅ pass

[github-actions]

Integration Test Results

14 tests   6 ✅  3s ⏱️
 1 suites  8 💤
 1 files    0 ❌

Results for commit e6c139e.

♻️ This comment has been updated with latest results.

[sprunk]

why?

[keithharvey]

why?

Short answer: they aren't engine API, and having them on Spring is misleading.

This came directly out of working on spring-split. When you split Spring into SpringSynced / SpringUnsynced / SpringShared based on the engine's actual type definitions, these five modules (I18N, Utilities, Debug, Lava, GetModOptionsCopy) show up as ~1,700 unmapped orphans — because they were never engine methods in the first place. They're BAR's own modules, monkey-patched onto Spring as a namespace convenience.

Detaching them makes the split cleaner: SpringX tables contain engine API, and game-level modules live under their own names. It also means we can type them properly in the library definitions without awkwardly extending or inheriting from SpringShared for things that have nothing to do with the engine.

Totally open to other ideas, this just seemed accurate to me if I was trying for "pure" types for the engine API.

[efrec]

I don't dislike separating code not sourced from the engine like this.

But I kind of do dislike a top-level "Utilities".

[keithharvey]

Superseded by #8403 — recreated with its head on beyond-all-reason instead of the fork; the whole migration stack now lives same-repo. Branch content is identical; review history stays readable here.