[Types] Inline LuaCATS busted+luassert type annotations - #8405
Open
keithharvey wants to merge 1 commit into
Open
[Types] Inline LuaCATS busted+luassert type annotations#8405keithharvey wants to merge 1 commit into
keithharvey wants to merge 1 commit into
Conversation
This was referenced Jul 22, 2026
Contributor
keithharvey
force-pushed
the
mig-busted-types
branch
from
July 25, 2026 03:41
2bb62e3 to
6a79f06
Compare
keithharvey
force-pushed
the
mig-busted-types
branch
from
July 25, 2026 05:08
6a79f06 to
6b2d608
Compare
keithharvey
force-pushed
the
mig-busted-types
branch
2 times, most recently
from
July 29, 2026 15:08
09160a7 to
36d639e
Compare
keithharvey
force-pushed
the
mig-busted-types
branch
from
July 29, 2026 15:47
36d639e to
e972bca
Compare
keithharvey
force-pushed
the
mig-busted-types
branch
from
July 29, 2026 17:48
e972bca to
d9d0e92
Compare
efrec
reviewed
Jul 29, 2026
efrec
approved these changes
Jul 29, 2026
keithharvey
force-pushed
the
mig-busted-types
branch
2 times, most recently
from
July 29, 2026 19:07
647817f to
b945ce4
Compare
keithharvey
force-pushed
the
fmt
branch
2 times, most recently
from
July 29, 2026 19:56
9b6bb4c to
087892a
Compare
keithharvey
force-pushed
the
mig-busted-types
branch
2 times, most recently
from
July 29, 2026 21:09
3aaa6c7 to
cced4f6
Compare
keithharvey
force-pushed
the
mig-busted-types
branch
from
July 29, 2026 22:17
cced4f6 to
b40426c
Compare
efrec
approved these changes
Jul 30, 2026
keithharvey
force-pushed
the
mig-busted-types
branch
from
July 30, 2026 01:10
b40426c to
5295b27
Compare
Vendored LuaCATS annotations for busted/luassert to provide IntelliSense for the unit-test surface. Lives on its own leaf so the discussion around 'vendoring LuaCATS types' can happen in isolation — prior pushback on the same direction in an earlier unit-testing PR makes this the right place to litigate it rather than burying it in a broader env commit. Why vendored instead of declared as a Lux dep: Lux does not yet support pulling LuaCATS annotations from library deps, and quick attempts to wire this up in Lux failed. Upstream tracking issue: lumen-oss/lux#953 — once that lands, these directories should be deleted in favor of declaring busted as a normal Lux dev-dep. Sources (pinned SHAs): - types/busted/ https://github.com/LuaCATS/busted @ 5ed85d0e016a5eb5eca097aa52905eedf1b180f1 - types/luassert/ https://github.com/LuaCATS/luassert @ d3528bb679302cbfdedefabb37064515ab95f7b9 See types/busted/provenance.md and types/luassert/provenance.md for per-directory upstream refs + license status.
keithharvey
force-pushed
the
mig-busted-types
branch
from
August 4, 2026 22:18
5295b27 to
63936d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Don't merge this PR by itself — it's one slice of a stacked review.
Merging an intermediate PR breaks the stack. The whole cleanup lands by
merging only the tip,
fmt-llm, which pulls in every branch below it.Part of BAR type-error cleanup. Rebuilds idempotently from
masterviajust bar::migrate::stylua-cleanup-generate.What it does: Hand-curated (not a codemod): vendors LuaCATS/busted and LuaCATS/luassert type annotations under
types/busted/andtypes/luassert/.Waits on lumen-oss/lux#953 to replace with a Lux dev-dep declaration.
Branch Topology
All branches in the BAR type-error cleanup stack — see Bulk Migrations for the migration log and how to run
just bar::migrate::stylua-cleanup. Regenerated deterministically byjust bar::migrate::stylua-cleanup-generate. Generated 2026-08-04 22:18:37 UTC.Leaves — each isolates one transform's diff vs
fmt:styluabar-lua-codemod bracket-to-dotbar-lua-codemod rename-aliasesbar-lua-codemod detach-bar-modules<hand curated><hand curated>Rollups — composite branches stacking the leaves and (for
fmt-llm) the env + LLM layers:master