[Types] LLM env layer (emmylua config, type stubs, manual fixes) - #8397
Open
keithharvey wants to merge 1 commit into
Open
[Types] LLM env layer (emmylua config, type stubs, manual fixes)#8397keithharvey wants to merge 1 commit into
keithharvey wants to merge 1 commit into
Conversation
This was referenced Jul 22, 2026
Closed
Closed
Contributor
This was referenced Jul 22, 2026
keithharvey
force-pushed
the
fmt-llm-source
branch
from
July 25, 2026 03:41
673a85b to
f90a69d
Compare
keithharvey
force-pushed
the
fmt-llm-source
branch
from
July 25, 2026 05:08
f90a69d to
12a6c23
Compare
keithharvey
force-pushed
the
fmt-llm-source
branch
from
July 25, 2026 06:04
12a6c23 to
67dcef0
Compare
keithharvey
force-pushed
the
fmt-llm-source
branch
2 times, most recently
from
July 29, 2026 15:47
52aa4f6 to
5180047
Compare
keithharvey
force-pushed
the
fmt-llm-source
branch
2 times, most recently
from
July 29, 2026 17:48
bfafbaf to
f88fd92
Compare
keithharvey
force-pushed
the
fmt-llm-source
branch
from
July 29, 2026 18:14
f88fd92 to
b32ab37
Compare
keithharvey
force-pushed
the
fmt-llm-source
branch
from
July 29, 2026 19:07
b32ab37 to
ecc8165
Compare
keithharvey
force-pushed
the
fmt-llm-source
branch
from
July 29, 2026 19:56
ecc8165 to
5f50e6b
Compare
keithharvey
commented
Jul 29, 2026
keithharvey
force-pushed
the
fmt-llm-source
branch
2 times, most recently
from
July 29, 2026 22:17
e9772e3 to
6441fa8
Compare
efrec
reviewed
Jul 30, 2026
efrec
reviewed
Jul 30, 2026
keithharvey
force-pushed
the
fmt-llm-source
branch
from
July 30, 2026 00:41
6441fa8 to
69821fa
Compare
efrec
approved these changes
Jul 30, 2026
keithharvey
force-pushed
the
fmt-llm-source
branch
2 times, most recently
from
July 30, 2026 01:32
bdef328 to
667ae95
Compare
…ixes One atomic layer commit: folds the emmylua-0.24 dangling-globals and springFunctions forward-declaration followups. The spring-split alias adoption (SetupAliases shim + SpringUnsynced call sites) is extracted — it ships with the engine rename, not the type env. CI moves to emmylua_check 0.24.0 in lockstep with dev.Containerfile. The gate reports errors only (severity 1); warnings and hints stay local — just bar::check for the full output, bar::check-errors for this gate's exact view.
keithharvey
force-pushed
the
fmt-llm-source
branch
from
August 4, 2026 22:18
667ae95 to
d1c6304
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Don't merge this PR by itself — it's one slice of a stacked review.
Merging an intermediate PR breaks the stack. The whole cleanup lands by
merging only the tip,
fmt-llm, which pulls in every branch below it.Part of BAR type-error cleanup. Human-curated env layer that prepares the codebase for the LLM type-fix pass.
This branch carries:
.emmyrc.jsonglobals and analyzer configtypes/*stubs for vendored/generated declarationsThe fix recipes the subsequent LLM pass (#8398) uses are catalogued in
SKILL.md— same rulebook that guides the subagents.Branch Topology
All branches in the BAR type-error cleanup stack — see Bulk Migrations for the migration log and how to run
just bar::migrate::stylua-cleanup. Regenerated deterministically byjust bar::migrate::stylua-cleanup-generate. Generated 2026-08-04 22:18:41 UTC.Leaves — each isolates one transform's diff vs
fmt:styluabar-lua-codemod bracket-to-dotbar-lua-codemod rename-aliasesbar-lua-codemod detach-bar-modules<hand curated><hand curated>Rollups — composite branches stacking the leaves and (for
fmt-llm) the env + LLM layers:master