Skip to content

[Types] rename-aliases - #8402

Open
keithharvey wants to merge 1 commit into
fmtfrom
mig-rename-aliases
Open

[Types] rename-aliases#8402
keithharvey wants to merge 1 commit into
fmtfrom
mig-rename-aliases

Conversation

@keithharvey

@keithharvey keithharvey commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Warning

Don't merge this PR by itself — it's one slice of a stacked review.
Merging an intermediate PR breaks the stack. The whole cleanup lands by
merging only the tip, fmt-llm, which pulls in every branch below it.

Part of BAR type-error cleanup. Rebuilds idempotently from master via just bar::migrate::stylua-cleanup-generate.

What it does: Renames deprecated Spring method aliases to their canonical names (e.g. Spring.GetMyTeamIDSpring.GetLocalTeamID) so call sites line up with the names the engine type stubs declare.

# rename-aliases -- deprecated aliases, e.g. GetMyTeamID -> GetLocalTeamID
bar-lua-codemod rename-aliases --path "$BAR_DIR" --exclude common/luaUtilities --exclude .lux --exclude recoil-lua-library --exclude mapgenerator

Branch Topology

All branches in the BAR type-error cleanup stack — see Bulk Migrations for the migration log and how to run just bar::migrate::stylua-cleanup. Regenerated deterministically by just bar::migrate::stylua-cleanup-generate. Generated 2026-08-05 20:58:55 UTC.

Leaves — each isolates one transform's diff vs fmt:

Branch Command Diff vs parent Units
fmt stylua 1433 files, +310598 −196454 ✅ pass
mig-bracket bar-lua-codemod bracket-to-dot 354 files, +8334 −8334 ✅ pass
👉 mig-rename-aliases — you are here bar-lua-codemod rename-aliases 179 files, +378 −378 ✅ pass
mig-detach-bar-modules bar-lua-codemod detach-bar-modules 185 files, +1946 −1836 ✅ pass
mig-integration-tests <hand curated> 27 files, +174 −173 ✅ pass
mig-busted-types <hand curated> 18 files, +1539 −92 ✅ pass

Rollups — composite branches stacking the leaves and (for fmt-llm) the env + LLM layers:

Branch Diff vs master Diff vs parent Units
mig 1453 files, +315392 −199699 532 files, +12227 −10678 ✅ pass
fmt-llm-source 1457 files, +315754 −199846 57 files, +394 −179 ✅ pass
fmt-llm 1458 files, +315802 −199864 32 files, +64 −34 ✅ pass

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

15 tests  ±0   7 ✅ ±0   4s ⏱️ ±0s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   0 ❌ ±0 

Results for commit 56c054a. ± Comparison against base commit 14c42dd.

♻️ This comment has been updated with latest results.

@keithharvey

Copy link
Copy Markdown
Collaborator Author

REGISTER_NAMED_LUA_CFUNC("GetMyPlayerID", GetLocalPlayerID);

This is in fact aliased by the engine and deprecated. We're a little unsure if this will ever actually get deprecated (super wide spread), but this is engine reality.

@keithharvey
keithharvey force-pushed the mig-rename-aliases branch 2 times, most recently from 9be1412 to ffcf71c Compare August 4, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant