[Types] rename-aliases - #8402
Open
keithharvey wants to merge 1 commit into
Open
Conversation
This was referenced Jul 22, 2026
Closed
Contributor
keithharvey
force-pushed
the
mig-rename-aliases
branch
2 times, most recently
from
July 25, 2026 05:08
99197a0 to
ebb4d29
Compare
keithharvey
force-pushed
the
fmt
branch
2 times, most recently
from
July 25, 2026 06:04
5ece360 to
2fc2bf6
Compare
keithharvey
force-pushed
the
mig-rename-aliases
branch
3 times, most recently
from
July 29, 2026 15:47
e6abd71 to
97c15aa
Compare
keithharvey
force-pushed
the
mig-rename-aliases
branch
from
July 29, 2026 17:48
97c15aa to
85efa79
Compare
keithharvey
force-pushed
the
fmt
branch
2 times, most recently
from
July 29, 2026 18:14
66ccba0 to
6e4e03a
Compare
keithharvey
force-pushed
the
mig-rename-aliases
branch
from
July 29, 2026 18:14
85efa79 to
534c850
Compare
keithharvey
force-pushed
the
mig-rename-aliases
branch
2 times, most recently
from
July 29, 2026 19:56
086cb9d to
488eae8
Compare
keithharvey
force-pushed
the
mig-rename-aliases
branch
from
July 29, 2026 21:09
488eae8 to
fe278f1
Compare
keithharvey
force-pushed
the
mig-rename-aliases
branch
from
July 29, 2026 22:17
fe278f1 to
06374e0
Compare
Collaborator
Author
This is in fact aliased by the engine and deprecated. We're a little unsure if this will ever actually get deprecated (super wide spread), but this is engine reality. |
keithharvey
force-pushed
the
mig-rename-aliases
branch
2 times, most recently
from
August 4, 2026 22:18
9be1412 to
ffcf71c
Compare
keithharvey
force-pushed
the
mig-rename-aliases
branch
from
August 5, 2026 20:59
ffcf71c to
56c054a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Don't merge this PR by itself — it's one slice of a stacked review.
Merging an intermediate PR breaks the stack. The whole cleanup lands by
merging only the tip,
fmt-llm, which pulls in every branch below it.Part of BAR type-error cleanup. Rebuilds idempotently from
masterviajust bar::migrate::stylua-cleanup-generate.What it does: Renames deprecated Spring method aliases to their canonical names (e.g.
Spring.GetMyTeamID→Spring.GetLocalTeamID) so call sites line up with the names the engine type stubs declare.Branch Topology
All branches in the BAR type-error cleanup stack — see Bulk Migrations for the migration log and how to run
just bar::migrate::stylua-cleanup. Regenerated deterministically byjust bar::migrate::stylua-cleanup-generate. Generated 2026-08-05 20:58:55 UTC.Leaves — each isolates one transform's diff vs
fmt:styluabar-lua-codemod bracket-to-dotbar-lua-codemod rename-aliasesbar-lua-codemod detach-bar-modules<hand curated><hand curated>Rollups — composite branches stacking the leaves and (for
fmt-llm) the env + LLM layers:master