Modifies the tests to use the defaults created in configprovider.py #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and formats the newly addded changes
ubaskota
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3334 +/- ##
==========================================
Coverage ? 93.19%
==========================================
Files ? 66
Lines ? 14411
Branches ? 0
==========================================
Hits ? 13431
Misses ? 980
Partials ? 0 ☔ View full report in Codecov by Sentry. |
ubaskota
changed the title
jonathan343
approved these changes
Jan 14, 2025
SamRemis
approved these changes
Jan 14, 2025
aws-sdk-python-automation
added a commit
that referenced
this pull request
Jan 14, 2025
* release-1.35.99: Bumping version to 1.35.99 Update endpoints model Update to latest models Modifies the tests to usse the defaults created in configprovider.py and formats the newly addded changes (#3334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Botocore has a number of unit tests that create a client using an empty ConfigValueStore object. Doing this causes the client constructor to lose the default arguments for configurations. This creates some extra work when we are resolving the arguments; for
request_min_compression_size_bytes, we just skip the validation all-together if the value isNonedue to this test.This PR fixes the tests to use the default botocore ConfigValueStore object. This allows us to re-enable the validation on
request_min_compression_size_bytes, properly throwing an error for aNonevalue. It also allows for future configurations to rely on their defaults when validating an input configuration value without having to code around these tests.