Don't use the nested scroll view in Column #2555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #746 |
This breaks overscroll. I looked into the PR that added this, which was an attempt to work-around a problem where a RecyclerView was nested in a scrollable column. We shouldn't ever do that, so this work-around should be unnecessary.
swankjesse
force-pushed
the
jwilson.0207.not_nested
branch
from
7294526 to
5f51f50
Compare
JakeWharton
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
If an NSV isn't overscrolling it would be because a parent reports itself as being able to consume the scroll events. Is something else scrollable up in the hierarchy? I will still approve, but since NSV is used everywhere normally anything like this should be some other problem that we created.
|
Lemme figure out what’s happening and follow-up here. |
|
We're unlikely to actually need NSV, unless we attempt something like a collapsing header component. So it's not a huge deal to switch for now. Just was a surprising culprit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks overscroll.
I looked into the PR that added this, which was an attempt to work-around a problem where a RecyclerView was nested in a scrollable column. We shouldn't ever do that, so this work-around should be unnecessary.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.