Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for tx messages #32572

Closed

Conversation

markopetkovic96
Copy link

#32425
I made a PR to get more information about this test. As I asked, after checked rx example, should the tx messages be similar to the rx messages? Create a packet, transmit can messages (with safety_tx_hook), update openpilot, and compare it with the previous panda state?

@github-actions github-actions bot added CI / testing car vehicle-specific labels May 30, 2024
Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Contributor

sshane commented May 30, 2024

The goal of the issue isn't to copy the existing test changing rx for tx. We want to ensure that any control message openpilot generates (CAN) the panda will accept and not block, causing a potential controls mismatch. The trick is getting openpilot to generate varied, but valid, messages to test with.

@sshane sshane closed this May 30, 2024
@markopetkovic96 markopetkovic96 deleted the test_models_fuzz branch May 30, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific CI / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants