Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Run MetaDrive test #34045

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

JakobSpahn
Copy link
Contributor

@JakobSpahn JakobSpahn commented Nov 18, 2024

Description

Resolves: #33207

Depends on:

Support pytest tools/sim/tests/test_metadrive_bridge.py on macOS

Changes


Test passes on my local M1 with North America Model.

The test currently still fails with Dragon Rider, but when switching back to MLSIM V4 it passes.

git checkout 34dde0bb36b528febee292891523e30e82835aac -- selfdrive/modeld/models/supercombo.onnx && scons -u -j$(nproc)

(Notably, on my Ubuntu reference Dragon Rider also fails: #34044)

@JakobSpahn JakobSpahn marked this pull request as draft November 18, 2024 16:20
@adeebshihadeh
Copy link
Contributor

Interesting that you get meaningfully different results on the different models. If it's the same behavior across both Ubuntu/macOS, then don't worry about it for the bounty.

Is the MetaDrive PR the only thing holding this up?

@JakobSpahn
Copy link
Contributor Author

Interesting that you get meaningfully different results on the different models.

It seems in the CI the car doesn't travel far enough for the difference to show up (see GH actions for ee14cd5).

Is the MetaDrive PR the only thing holding this up?

Yes, although after the MetaDrive PR is merged I will open a second PR that merges the changes into the minimal MetaDrive branch.

Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 30, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Dec 2, 2024
@github-actions github-actions bot removed the stale label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get MetaDrive simulator working on macOS
3 participants