-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Run MetaDrive test #34045
base: master
Are you sure you want to change the base?
macOS: Run MetaDrive test #34045
Conversation
Interesting that you get meaningfully different results on the different models. If it's the same behavior across both Ubuntu/macOS, then don't worry about it for the bounty. Is the MetaDrive PR the only thing holding this up? |
It seems in the CI the car doesn't travel far enough for the difference to show up (see GH actions for ee14cd5).
Yes, although after the MetaDrive PR is merged I will open a second PR that merges the changes into the minimal MetaDrive branch. |
This reverts commit ee14cd5.
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Description
Resolves: #33207
Depends on:
Support
pytest tools/sim/tests/test_metadrive_bridge.py
on macOSChanges
OpenpilotPrefix
(depends on tmpfs).Test passes on my local M1 with North America Model.
The test currently still fails with Dragon Rider, but when switching back to MLSIM V4 it passes.git checkout 34dde0bb36b528febee292891523e30e82835aac -- selfdrive/modeld/models/supercombo.onnx && scons -u -j$(nproc)
(Notably, on my Ubuntu reference Dragon Rider also fails: #34044)