GitHub CI setup-with-retry speedup - alternative approach, entirely removing Docker #36071
+248
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workinright
changed the title
workinright
changed the title
workinright
force-pushed
the
master
branch
27 times, most recently
from
7f82f2d to
08d8c43
Compare
workinright
force-pushed
the
master
branch
8 times, most recently
from
8cc631f to
f644523
Compare
workinright
force-pushed
the
master
branch
12 times, most recently
from
8cce523 to
1e31ec7
Compare
workinright
force-pushed
the
master
branch
6 times, most recently
from
0103837 to
16db7fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30706 , however unlike #35873 follows a different approach of removing Docker (which is preferred according to my talk with @adeebshihadeh ). Both implementations have extremely similar performance, since they work essentially the same (the only remaining limiting factors being network, disk I/O speed and the CPU for Zstandard decompression). The only practical difference between them is the lack of a ~400 line docker pull reimplementation in this approach.
Still a draft for now, as (probably because of the weirdness of the GitHub CI Ubuntu image) we're running into some weird Python problem. That's in contrast to the Docker proposed approach, which is already fully working.