Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for configurable maximum allowed initiation interval (II) in the architecture specification. This allows users to specify the maximum II value via the max_allowed_ii_by_hw field in YAML configuration files.
- Added
max_allowed_ii_by_hwfield to architecture YAML specification with default value of 20 - Updated YAML parsing to handle the new configuration parameter
- Modified code generation to support string attributes in constant literals
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/arch_spec/architecture.yaml | Added max_allowed_ii_by_hw field and updated num_registers |
| test/arch_spec/arch_spec_example.yaml | Added max_allowed_ii_by_hw field and adjusted grid dimensions |
| lib/NeuraDialect/Transforms/MapToAcceleratorPass.cpp | Updated YAML parsing to read max_ii configuration and use it instead of hardcoded value |
| lib/NeuraDialect/Transforms/GenerateCodePass.cpp | Added support for string attributes in constant literal generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tancheng
reviewed
Oct 13, 2025
Collaborator
Author
|
Here is the link #154 for the function %arg issue |
tancheng
reviewed
Oct 17, 2025
tancheng
reviewed
Oct 17, 2025
- Convert camelCase variable names to snake_case for consistency - Update variable names in YAML parsing section - Improve code readability and maintainability
n0thingNoob
force-pushed
the
architecture_spec
branch
from
1164948 to
77a4a5f
Compare
tancheng
approved these changes
Oct 17, 2025
n0thingNoob
force-pushed
the
architecture_spec
branch
from
64b3f99 to
2c42a43
Compare
tancheng
reviewed
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add max_allowed_ii_by_hw to arch spec. The default max II is 20.