translator: move EnvoyProxy validation out of Provider #7009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7009 +/- ##
==========================================
- Coverage 71.05% 71.03% -0.03%
==========================================
Files 227 227
Lines 40441 40495 +54
==========================================
+ Hits 28736 28765 +29
- Misses 10009 10028 +19
- Partials 1696 1702 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rudrakhp
previously approved these changes
Sep 19, 2025
| } | ||
| case egv1a1.ProxyAccessLogFormatTypeJSON: | ||
| if setting.Format.JSON == nil { | ||
| err := fmt.Errorf("unable to configure access log when using JSON format but \"json\" field being empty") |
There was a problem hiding this comment.
Curious why this check is removed.
There was a problem hiding this comment.
EG use JSON as default now, and nil means use default JSON output.
rudrakhp
previously approved these changes
Sep 20, 2025
cnvergence
previously approved these changes
Sep 24, 2025
arkodg
reviewed
Sep 24, 2025
arkodg
reviewed
Sep 25, 2025
arkodg
reviewed
Sep 25, 2025
zirain
force-pushed
the
fix-6752
branch
2 times, most recently
from
f40b7ec to
adcc255
Compare
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain
commented
Sep 26, 2025
|
|
||
| r.log.Error(err, fmt.Sprintf("failed process TLS SecretRef for EnvoyProxy for gatewayClass %s", managedGC.Name)) | ||
| gc := status.SetGatewayClassAccepted( | ||
| managedGC.DeepCopy(), |
There was a problem hiding this comment.
I didn't understand why we do deepcopy here, we post GC with old status to gatewayapi layer in the past.
cc @arkodg
Signed-off-by: zirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
xref: #6752