Don't set content-length header for HEAD requests with empty body #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extra function clause prevents the `content-length` (equals 0) header from being added to the headers of a `HEAD` request with an empty body. This is compliant with [Amazon's specification of the HeadObject API endpoint] that doesn't specify the `content-length` header as part of the URI Request Parameters. As a benefit, this makes ExAws and ExAws.S3 work with [Garage](https://garagehq.deuxfleurs.fr/), which, unlike [Minio](https://min.io), doesn't gracefully handle the extraneous presence of the `{"content-length", "0"}` header in the request headers of the HeadObject call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra function clause in
lib/ex_aws/operation/s3.exprevents thecontent-lengthheader from being added to the headers of aHEADrequest with an empty body (in which case the body of the request is an empty string and the value of that header would be "0").This is compliant with Amazon's specification of the HeadObject API endpoint, as it doesn't specify the
content-lengthheader as part of the URI Request Parameters.As an added benefit, this makes ExAws and ExAws.S3 work with Garage. Unlike Minio, Garage doesn't gracefully handle the extraneous presence of the
{"content-length", "0"}header in the request headers of the HeadObject call.[x] Run
mix formatusing a recent version of Elixir[x] Run
mix dialyzerto make sure the typing is correct[x] Run
mix testto ensure no tests have broken (also please make sure you've added tests for your particular change, where appropriate) (no new tests added)