Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set content-length header for HEAD requests with empty body #1067

Merged
merged 2 commits into from
Sep 10, 2024

Commits on Jun 24, 2024

  1. Don't set content-length header for HEAD requests with empty body

    This extra function clause prevents the `content-length` (equals 0)
    header from being added to the headers of a `HEAD` request with an empty
    body. This is compliant with [Amazon's specification of the HeadObject
    API endpoint] that doesn't specify the `content-length` header as part
    of the URI Request Parameters. As a benefit, this makes ExAws and
    ExAws.S3 work with [Garage](https://garagehq.deuxfleurs.fr/), which,
    unlike [Minio](https://min.io), doesn't gracefully handle the extraneous
    presence of the `{"content-length", "0"}` header in the request headers
    of the HeadObject call.
    waseigo committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    43d7fa5 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Configuration menu
    Copy the full SHA
    6a23dc2 View commit details
    Browse the repository at this point in the history