Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set content-length header for HEAD requests with empty body #1067

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Don't set content-length header for HEAD requests with empty body #1067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d7fa5
Don't set content-length header for HEAD requests with empty body
waseigo Jun 24, 2024
6a23dc2
Added put_content_length_header clause for DELETE too
waseigo Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/ex_aws/operation/s3.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ defmodule ExAws.Operation.S3 do

defp put_content_length_header(headers, "", :get), do: headers

defp put_content_length_header(headers, "", :head), do: headers

defp put_content_length_header(headers, "", :delete), do: headers

defp put_content_length_header(headers, body, _) do
Map.put(headers, "content-length", IO.iodata_length(body) |> Integer.to_string())
end
Expand Down