Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: allow wildcard in http allowed_host #421

Closed
Mossaka opened this issue May 1, 2022 · 6 comments
Closed

Feature: allow wildcard in http allowed_host #421

Mossaka opened this issue May 1, 2022 · 6 comments

Comments

@Mossaka
Copy link
Contributor

Mossaka commented May 1, 2022

We should have a allowed_http_hosts = ["*"] option to allow all all hosts. This is dangerous but in rare cases should be useful - like handling a webhook callback.

@lann
Copy link
Collaborator

lann commented May 3, 2022

While I can see the necessity of something like this, I think we need to be cautious here. Allowing unrestricted outbound connections is pretty powerful; by default this would include outbound connections to the host's local network, localhost, etc.

@Mossaka
Copy link
Contributor Author

Mossaka commented May 3, 2022

My thought is that we should clearly document this and put a big WARNING sign when user is using the "*" in their component.

@lann
Copy link
Collaborator

lann commented May 3, 2022

I would be happier if we made the string scarier 🙂 , maybe something like insecure:allow-all?

@Mossaka
Copy link
Contributor Author

Mossaka commented May 3, 2022

Will this be a string in allowed_http_hosts, or it deserves its own component field?

@lann
Copy link
Collaborator

lann commented May 3, 2022

I'm fine with it going in allowed_http_hosts (the : keeps it from being a valid host name). I think we'll want to adjust the fields in the future anyway for e.g. deislabs/wasi-experimental-http#87

@Mossaka
Copy link
Contributor Author

Mossaka commented May 6, 2022

updated the pr to have insecure:allow-all

@Mossaka Mossaka closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants