[Farewell, Interaction]: Step 1 of removing the Interaction class #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review! @yaichenbaum |
d2dyno1
changed the title
lukeblevins
reviewed
Mar 14, 2021
yaira2
requested changes
Mar 18, 2021
yaira2
approved these changes
Mar 18, 2021
|
@tsvietOK Do you have any thoughts on this change? |
lukeblevins
approved these changes
Mar 20, 2021
yaira2
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the very first part of removing the
Interactionclass. Since the overall scope is very large, I've split it into multiple parts. For #4180Many UI event handlers have been moved to
GenericFileBrowserandGridViewBrowser. This is not ideal because a lot of the code is duplicated between these classes. I propose the best MVVM solution I could think of. The way it works is, we have aBaseLayoutCommandsViewModelclass inBaseLayoutwhich contains all UIICommands and those commands call functions inIBaseLayoutCommandImplementationModelinterface that contains implementation for these commands.Since this is a big change that'll last for long, we must choose right and pick a sufficient solution.
Side note: The work hasn't been done using this pattern yet but classes and example usage have been added.
Update
This pattern has been approved and implemented.
Let me know what do you think of this solution! @yaichenbaum @duke7553 @gave92