Skip to content

Conversation

@gbhat618
Copy link
Contributor

@gbhat618 gbhat618 commented Mar 13, 2025

JIRA: https://issues.jenkins.io/browse/JENKINS-75409

The -noCertificateCheck and -cert options of the remoting library are currently not covered by the automated tests. Trying to add integration tests by using RealJenkinsRule#https in jenkinsci/jenkins#10396

Testing done

Tested by it's usage in jenkinsci/jenkins#10396

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@gbhat618 gbhat618 changed the title [JENKINS-75409] Add the -noCertificateCheck and -cert option to IAR [JENKINS-75409] Add -noCertificateCheck and -cert option to IAR Mar 13, 2025
@gbhat618 gbhat618 marked this pull request as ready for review March 13, 2025 19:01
@gbhat618 gbhat618 marked this pull request as draft March 13, 2025 19:02
@gbhat618 gbhat618 marked this pull request as ready for review March 13, 2025 19:04
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible but hold off until the downstream PR is complete.

@gbhat618
Copy link
Contributor Author

The core IT is working in downstream PR, and success build

@timja timja merged commit 8109bbb into jenkinsci:master Mar 24, 2025
15 checks passed
@gbhat618 gbhat618 deleted the add-certificate-params-to-IAR branch March 24, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants