fix/consider-version-compatibility-on-extra-mounts-in-model-serving #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:lib
9 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
lizable
force-pushed
the
05-30-feature_add-extra-mount-and-mount-destination-on-routing-info
branch
from
3ddb6c1 to
8dcb937
Compare
lizable
force-pushed
the
05-30-fix_consider-version-compatibility-on-extra-mounts-in-model-serving
branch
from
fdb5d30 to
b49a335
Compare
yomybaby
requested changes
May 30, 2024
lizable
force-pushed
the
05-30-fix_consider-version-compatibility-on-extra-mounts-in-model-serving
branch
from
67ee4af to
2b1381f
Compare
yomybaby
requested changes
May 30, 2024
yomybaby
requested changes
May 31, 2024
|
I fixed the minor issue which is spotted by @yomybaby, |
yomybaby
approved these changes
May 31, 2024
react/src/pages/RoutingListPage.tsx
Outdated
Comment on lines
340
to
346
| {_.map(endpoint?.extra_mounts, (vfolder: VFolder) => { | ||
| return ( | ||
| <Flex direction="row" gap={'xxs'}> | ||
| <FolderOutlined /> {vfolder.name} | ||
| </Flex> |
There was a problem hiding this comment.
Suggested change
| {_.map(endpoint?.extra_mounts, (vfolder: VFolder) => { | |
| return ( | |
| <Flex direction="row" gap={'xxs'}> | |
| <FolderOutlined /> {vfolder.name} | |
| </Flex> | |
| {_.map(endpoint?.extra_mounts, (vfolder) => { | |
| return ( | |
| <Flex direction="row" gap={'xxs'}> | |
| <FolderOutlined /> {vfolder?.name} | |
| </Flex> |
yomybaby
force-pushed
the
05-30-feature_add-extra-mount-and-mount-destination-on-routing-info
branch
from
75de60a to
a70f290
Compare
Base automatically changed from
05-30-feature_add-extra-mount-and-mount-destination-on-routing-info
to
main
May 31, 2024 06:55
…ture support in server-side
…tead of redundant vfolder query
yomybaby
force-pushed
the
05-30-fix_consider-version-compatibility-on-extra-mounts-in-model-serving
branch
from
4de9bc2 to
a1316d0
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.85% (-0% 🔻) |
140/4915 |
| 🔴 | Branches | 3.31% (-0.02% 🔻) |
110/3324 |
| 🔴 | Functions | 1.55% (-0% 🔻) |
25/1613 |
| 🔴 | Lines | 2.74% (-0% 🔻) |
132/4825 |
Test suite run success
48 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from a1316d0
yomybaby
deleted the
05-30-fix_consider-version-compatibility-on-extra-mounts-in-model-serving
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides conditionally showing extra mount vfolders only when Core version supports its feature.
Checklist: (if applicable)