-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/consider-version-compatibility-on-extra-mounts-in-model-serving #2447
fix/consider-version-compatibility-on-extra-mounts-in-model-serving #2447
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3ddb6c1
to
8dcb937
Compare
fdb5d30
to
b49a335
Compare
67ee4af
to
2b1381f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the minor issue which is spotted by @yomybaby, |
react/src/pages/RoutingListPage.tsx
Outdated
{_.map(endpoint?.extra_mounts, (vfolder: VFolder) => { | ||
return ( | ||
<Flex direction="row" gap={'xxs'}> | ||
<FolderOutlined /> {vfolder.name} | ||
</Flex> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{_.map(endpoint?.extra_mounts, (vfolder: VFolder) => { | |
return ( | |
<Flex direction="row" gap={'xxs'}> | |
<FolderOutlined /> {vfolder.name} | |
</Flex> | |
{_.map(endpoint?.extra_mounts, (vfolder) => { | |
return ( | |
<Flex direction="row" gap={'xxs'}> | |
<FolderOutlined /> {vfolder?.name} | |
</Flex> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
75de60a
to
a70f290
Compare
…ture support in server-side
…tead of redundant vfolder query
4de9bc2
to
a1316d0
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 2.85% (-0% 🔻) |
140/4915 |
🔴 | Branches | 3.31% (-0.02% 🔻) |
110/3324 |
🔴 | Functions | 1.55% (-0% 🔻) |
25/1613 |
🔴 | Lines | 2.74% (-0% 🔻) |
132/4825 |
Test suite run success
48 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from a1316d0
This PR provides conditionally showing extra mount vfolders only when Core version supports its feature.
Checklist: (if applicable)