add: providing additional vfolder mounts and arbitrary model definition path in model service launcher

[lizable]

• Related: backend.ai#2218
• Prerequisites:
  • all-set configuration to creating / modifying model-service.
  • wsproxy v2 configuration
  • model-definition.yaml file

This PR adds two features in model service launcher, supporting arbitrary path of model definition file (previously set to /models and model-definition.yaml(or yml) file, and providing additional mounts and aliasing on other vfolders.

⚠️ NOTE: When updating the model service, it doesn't applied immediately. It applies when there's no corresponding session
in running status, which represents "PROVISIONING" or "READY" status of model service.

Test

• Check whether you can create model service with no additional configuration, just model folder with model-definition.yml file inside. (default model folder mount path would be /models)
• Check whether you can create model service with setting arbitrary path of mount destination for model folder (e.g. /test)
• Check whether you can create model service with setting user-defined model definition file in model folder to mount by renaming it.
• Check whether you can mount a general type folder with aliasing if needed

Screenshot(s)

• Creating model service

  After	Before

• Modifying model service

  After	Before

Checklist: (if applicable)

• Mention to the original issue
• Documentation
• Minimum required manager version
• Specific setting for review (eg., KB link, endpoint or how to setup)
• Minimum requirements to check during review
• [] Test case(s) to demonstrate the difference of before/after

[lizable]

• add: providing additional vfolder mounts and arbitrary model definition path in model service launcher #2437 : 2 dependent PRs (#2443 , #2448 ) 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lizable and the rest of your teammates on Graphite

[github-actions]

Coverage report for ./react

St.❔	Category	Percentage	Covered / Total
🔴	Statements	2.85% (-0.01% 🔻)	140/4905
🔴	Branches	3.33% (-0.01% 🔻)	110/3301
🔴	Functions	1.55% (-0.01% 🔻)	25/1611
🔴	Lines	2.74% (-0.01% 🔻)	132/4815

Test suite run success

48 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 1d25210

[yomybaby]

You don't need an extra state to update some component based on the form's value. Instead of using an extra state, you can wrap the part you want to update using <Form.Item noStyle shouldUpdate ...>. After that, you can delete the selectedModelFolder state, updateSelectedModelFolder, and the useEffect for that.

Some like this(I have not tested below code.):

Suggested change

	}}
	/>
	</>
	<Form.Item noStyle shouldUpdate={(prev,cur)=>prev.vFolderName !== cur.vFolderName}>
	{()=>{
	return <VFolderTableFormItem
	rowKey={'id'}
	label={t('modelService.AdditionalMounts')}
	filter={(vf) =>
	vf.name !== formRef.current?.getFieldValue('vFolderName') &&
	vf.status === 'ready' &&
	vf.usage_mode !== 'model'
	}
	tableProps={{
	size: 'small',
	}}
	/>
	}}
	</Form.Item>

[yomybaby]

Please check below:

• When the user enters Mount Destination For Model Folder and then makes it empty again, the user gets an error when submitting:

{
    "type": "https://api.backend.ai/probs/invalid-api-params",
    "title": "Missing or invalid API parameters.",
    "msg": "Alias name cannot be empty."
}

[lizable]

For now, there's no way to import alias of extra mounted vfolders, unless fetching from server.

[yomybaby]

This feedback is also not resolved.

[yomybaby]

If you do not wrap the <Form.Item noStyle shouldUpdate={...}>, this part will not re-render when vFolderName is changed. Please check my previous comment again.

[yomybaby]

LGTM, but I'll merge this after reviewing the top of the stack. #2447

[yomybaby]

Merge activity

• May 31, 2:51 AM EDT: @yomybaby started a stack merge that includes this pull request via Graphite.
• May 31, 2:52 AM EDT: @yomybaby merged this pull request with Graphite.