Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/add-extra-mount-and-mount-destination-on-routing-info #2443

Merged
merged 3 commits into from
May 31, 2024
Merged

feature/add-extra-mount-and-mount-destination-on-routing-info #2443

merged 3 commits into from
May 31, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented May 30, 2024 •
edited
Loading

This PR adds two information on routing info page:

  • extra mounts folder list
  • model mount folder with mount destination
After Before
Screenshot 2024-05-30 at 2.59.14 PM.png Screenshot 2024-05-30 at 2.59.34 PM.png

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@lizable Graphite App
Copy link
Contributor Author

lizable commented May 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lizable and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:M 30~100 LoC label May 30, 2024
@lizable lizable mentioned this pull request May 30, 2024
Merged
9 tasks
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC and removed size:M 30~100 LoC labels May 30, 2024
@lizable lizable force-pushed the feature/refactor-model-storage-mount-in-model-service-launcher branch from b8bcccc to 94cddaa Compare May 30, 2024 05:57
@lizable lizable force-pushed the 05-30-feature_add-extra-mount-and-mount-destination-on-routing-info branch from 2717f6b to 3ddb6c1 Compare May 30, 2024 05:57
@lizable lizable marked this pull request as ready for review May 30, 2024 06:01
@lizable lizable mentioned this pull request May 30, 2024
Merged
6 tasks
@lizable lizable requested review from ironAiken2 and yomybaby May 30, 2024 08:07
@lizable lizable mentioned this pull request May 30, 2024
Draft
6 tasks
ironAiken2
ironAiken2 previously requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about endpoint query data field. ref

yomybaby
yomybaby requested changes May 30, 2024
View reviewed changes
@lizable lizable force-pushed the 05-30-feature_add-extra-mount-and-mount-destination-on-routing-info branch from 3ddb6c1 to 8dcb937 Compare May 30, 2024 09:32
@lizable lizable requested review from ironAiken2 and yomybaby May 30, 2024 09:54
yomybaby
yomybaby approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge together after approving #2447.

@yomybaby yomybaby dismissed ironAiken2’s stale review May 30, 2024 10:28

This is resolved in an upstack #2447.

@yomybaby Graphite App
Copy link
Member

yomybaby commented May 31, 2024 •
edited
Loading

Merge activity

  • May 31, 2:51 AM EDT: @yomybaby started a stack merge that includes this pull request via Graphite.
  • May 31, 2:54 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 31, 2:55 AM EDT: @yomybaby merged this pull request with Graphite.

Base automatically changed from feature/refactor-model-storage-mount-in-model-service-launcher to main May 31, 2024 06:52
@yomybaby yomybaby force-pushed the 05-30-feature_add-extra-mount-and-mount-destination-on-routing-info branch from 75de60a to a70f290 Compare May 31, 2024 06:53
@github-actions GitHub Actions
Copy link

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
2.84% (+0% 🔼)
 140/4924
🔴 Branches
3.33% (-0% 🔻)
 110/3303
🔴 Functions
1.55% (-0% 🔻)
 25/1612
🔴 Lines
2.73% (+0% 🔼)
 132/4834

Test suite run success

48 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from a70f290

@yomybaby yomybaby merged commit 1d8c3a7 into main May 31, 2024
6 checks passed
@yomybaby yomybaby deleted the 05-30-feature_add-extra-mount-and-mount-destination-on-routing-info branch May 31, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

@ironAiken2 ironAiken2 Awaiting requested review from ironAiken2

Assignees

@lizable lizable

Labels
area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizable @yomybaby @ironAiken2