conda-build: Add 'windows-latest' to conda build workflow

[jjerphan]

Reference Issues/PRs

Follow-up of #318.
Towards #190.

What does this implement/fix? Explain your changes.

Add Windows to the conda build workflow.

Any other comments?

It is willingly breaking other configurations on the CI to find one that works for Windows on conda-forge.

[jjerphan]

pcre cannot be linked on Windows for now, eventhough it apparently is resolved.

There's no CMake configuration for the version of pcre distributed on conda-forge for Windows.

conda-forge/pcre-feedstock#24 is improving the build for Windows regarding CMake.

[jjerphan]

I tried many things but I still obtain linker errors for the generated sources of the .proto files at the end of the build .

Those errors are due to symbols that are present in the object files of the generated source but that are missing in the shared library of protobuf.

There are 5 missing symbols:

"private: static char const * const * const google::protobuf::FieldDescriptor::kCppTypeToName" (?kCppTypeToName@FieldDescriptor@protobuf@google@@0QBQEBDB)

"class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)

"void * const * const google::protobuf::internal::kGlobalEmptyTable" (?kGlobalEmptyTable@internal@protobuf@google@@3QBQEAXB)

"struct google::protobuf::internal::DescriptorTable const descriptor_table_google_2fprotobuf_2fany_2eproto" (?descriptor_table_google_2fprotobuf_2fany_2eproto@@3UDescriptorTable@internal@protobuf@google@@B)

"struct google::protobuf::AnyDefaultTypeInternal google::protobuf::_Any_default_instance_" (?_Any_default_instance_@protobuf@google@@3UAnyDefaultTypeInternal@12@A)

The following is used:

• libprotobuf==3.20.3
• protobuf==3.20.3
• MSVC 19.36.32535.0
• the dynamic runtime (by specifying /MD)

Missing symbols for similar configurations also have been reported in some currently open issues of protobuf. such as:

• Failed to Build Visual Stuido C++ Project with .pb.h and .pb.cc  protocolbuffers/protobuf#9676 and to
• C++: x64-linker problem with ArenaString method ExplicitlyConstructed protocolbuffers/protobuf#11479

All linker errors

6>arcticdb_proto.lib(config.pb.obj) : error LNK2001: unresolved external symbol "private: static char const * const * const google::protobuf::FieldDescriptor::kCppTypeToName" (?kCppTypeToName@FieldDescriptor@protobuf@google@@0QBQEBDB)
6>arcticdb_proto.lib(logger.pb.obj) : error LNK2001: unresolved external symbol "private: static char const * const * const google::protobuf::FieldDescriptor::kCppTypeToName" (?kCppTypeToName@FieldDescriptor@protobuf@google@@0QBQEBDB)
6>arcticdb_proto.lib(descriptors.pb.obj) : error LNK2001: unresolved external symbol "private: static char const * const * const google::protobuf::FieldDescriptor::kCppTypeToName" (?kCppTypeToName@FieldDescriptor@protobuf@google@@0QBQEBDB)
6>arcticdb_proto.lib(storage.pb.obj) : error LNK2001: unresolved external symbol "private: static char const * const * const google::protobuf::FieldDescriptor::kCppTypeToName" (?kCppTypeToName@FieldDescriptor@protobuf@google@@0QBQEBDB)
6>arcticdb_proto.lib(nfs_backed_storage.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(s3_storage.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(storage.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(lmdb_storage.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(mongo_storage.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(config.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(utils.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(logger.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(descriptors.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::internal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,8> google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@$07@123@A)
6>arcticdb_proto.lib(config.pb.obj) : error LNK2001: unresolved external symbol "void * const * const google::protobuf::internal::kGlobalEmptyTable" (?kGlobalEmptyTable@internal@protobuf@google@@3QBQEAXB)
6>arcticdb_proto.lib(logger.pb.obj) : error LNK2001: unresolved external symbol "void * const * const google::protobuf::internal::kGlobalEmptyTable" (?kGlobalEmptyTable@internal@protobuf@google@@3QBQEAXB)
6>arcticdb_proto.lib(descriptors.pb.obj) : error LNK2001: unresolved external symbol "void * const * const google::protobuf::internal::kGlobalEmptyTable" (?kGlobalEmptyTable@internal@protobuf@google@@3QBQEAXB)
6>arcticdb_proto.lib(storage.pb.obj) : error LNK2001: unresolved external symbol "void * const * const google::protobuf::internal::kGlobalEmptyTable" (?kGlobalEmptyTable@internal@protobuf@google@@3QBQEAXB)
6>arcticdb_proto.lib(storage.pb.obj) : error LNK2001: unresolved external symbol "struct google::protobuf::internal::DescriptorTable const descriptor_table_google_2fprotobuf_2fany_2eproto" (?descriptor_table_google_2fprotobuf_2fany_2eproto@@3UDescriptorTable@internal@protobuf@google@@B)
6>arcticdb_proto.lib(storage.pb.obj) : error LNK2001: unresolved external symbol "struct google::protobuf::AnyDefaultTypeInternal google::protobuf::_Any_default_instance_" (?_Any_default_instance_@protobuf@google@@3UAnyDefaultTypeInternal@12@A)

[jjerphan]

Potential cause of failure to have a look at: the packaging of abseil and libprotobuf on conda-forge.

[h-vetinari]

Potential cause of failure to have a look at: the packaging of abseil and libprotobuf on conda-forge.

I haven't looked at the issues here, but the only hard requirement you need w.r.t. this ATM is to compile with C++17 (or perhaps C++20).

[jjerphan]

I haven't looked at the issues here, but the only hard requirement you need w.r.t. this ATM is to compile with C++17 (or perhaps C++20).

We already compile with C++17, the problem lies in the code-base with some code for headers being inlined unusually via macros (I did have time to have a look at that yet). @Klaim might be able to give more details in this regard.

[Klaim]

From memory (didnt get back to this yet): The issue is that the symbols that should be generated for the objects coming from compiling the protobuf-generated code are correctly generated but for some reason they are not found on linking.
The object files being brought into another lib then another lib might be making this complicated but I remember when we investigated we checked that the symbols were correctly available but the linking step was still failing.
Once I fix the issues with the inline headers #943 I will investigate more.
That issue might be related because it's bascially making the whole program Ill-Formed, No Diagnostic Required (IFNDR), which basically means the whole program is broken and we cannot assume anything correctly without fixing that first.

[jjerphan]

Failures might be related to conda-forge/libprotobuf-feedstock#201.

[jjerphan]

Closing for now, see #1412.