agentHost: Own SDK auto-download preference - #334316
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing session and window gates still prevent signed-out users from reaching the offer when the experiment is disabled.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSdkSetupNotification.ts — This does not make the offer independent of the signed-out experiment end to end. The notification… |
What changed in this PR
Moves Agent Host SDK download offers ahead of sign-in, entitlement, and experiment checks.
Changes:
- Offers missing SDK downloads to all users.
- Keeps missing-account guidance behind existing signed-out checks.
- Adds state-transition tests.
| File | Description |
|---|---|
agentHostSdkSetupNotification.ts |
Reorders setup-state decisions. |
agentHostSdkSetupNotification.test.ts |
Tests independent download offers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Base:
|
TylerLeonhardt
force-pushed
the
tyleonha/agent-sdk-download-offer
branch
from
September 3, 2026 21:01
4c682d1 to
ae72f5e
Compare
Check for a missing SDK before account, entitlement, and signed-out experiment gates so every user can consent to the required download. Keep missing-account guidance behind the existing signed-out checks and cover both sides of the decision boundary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Publish lazy SDK download lifecycle through the setup channel so first use dismisses the download offer and refreshes setup after completion. Persist the same standing consent as the Download action and bound failed retries to one attempt per window. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TylerLeonhardt
force-pushed
the
tyleonha/agent-sdk-download-offer
branch
from
September 3, 2026 22:54
ae72f5e to
781fc7e
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TylerLeonhardt
marked this pull request as ready for review
September 4, 2026 23:48
TylerLeonhardt
enabled auto-merge (squash)
September 4, 2026 23:48
Member
Author
|
I also ran a full build and verified this did what it should |
This was referenced Sep 5, 2026
Explain download-on-use when models are available, react to model availability changes, and preserve the Download action and no-model wording. Fixes #334668 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 5, 2026
Keep the upstream import placements after merging #334677, removing duplicate-identifier compilation errors from the provider and its tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #334675.
Summary
agent-host-storage.json, on the machine that owns the SDK cache.Sequencerand one download-activity state; duplicate explicit requests short-circuit before entering the queue.Testing
npm run transpile-clientnpm run typecheck-clientnpm run eslint -- <changed TypeScript files>.\scripts\test.bat --run src\vs\platform\agentHost\test\common\agentSdkSetup.test.ts --run src\vs\platform\agentHost\test\node\agentSdkSetupChannel.test.ts --run src\vs\platform\agentHost\test\node\agentConfigurationService.test.ts --run src\vs\platform\agentHost\test\node\agentSdkDownloader.test.ts --run src\vs\platform\agentHost\test\node\agentHostServices.test.ts(64 passing).\scripts\test.bat --run src\vs\platform\agentHost\test\node\claudeAgent.test.ts --run src\vs\platform\agentHost\test\node\codex\codexModelRefresh.test.ts --grep "agent SDK setup channel"(18 passing).\scripts\test.bat --run src\vs\platform\agentHost\test\node\codex\codexModelRefresh.test.ts --grep "restored model waits|queues a fresh model refresh"(2 passing).\scripts\test.bat --run src\vs\workbench\contrib\chat\test\browser\agentSessions\agentHostSdkSetupNotification.test.ts(36 passing).\scripts\test-integration.bat --run src\vs\platform\agentHost\test\node\claudeAgent.integrationTest.ts(5 passing)rnrnFullnpm run compileremains locally blocked by an unrelated stale@vscode/markdown-editorAPI mismatch; main-source typecheck and transpilation pass.SDK notification follow-up
Fixes #334668. Includes the notification fix from #334672.
Follow-up validation: 45 targeted SDK setup notification and session target picker tests passed, along with transpilation, ESLint, and hygiene checks.