Skip to content

Add Agents Window taskbar shortcut and icons - #335333

Merged
Dmitriy Vasyura (dmitrivMS) merged 9 commits into
mainfrom
agents/add-agents-window-shortcut
Sep 10, 2026
Merged

Add Agents Window taskbar shortcut and icons#335333
Dmitriy Vasyura (dmitrivMS) merged 9 commits into
mainfrom
agents/add-agents-window-shortcut

Conversation

@dmitrivMS

@dmitrivMS Dmitriy Vasyura (dmitrivMS) commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator
  • Add an Agents Window task to the Windows taskbar jump list
  • Launch it through the existing --agents mode
  • Use the distro-mixed sessions.ico asset for the jump-list task and resulting Windows taskbar button, so Stable, Insiders, and Exploration receive matching product-quality branding
  • Expose each native CodeWindow icon path through generic opened-window metadata
  • Have Switch Window render the icon advertised by the window, preserving existing file and workspace icons when a native icon is not provided

Screenshots

image image

Related issues

Fixes #335321
Fixes #315734
Fixes #315935

Add an Agents Window task to the Windows jump list using the existing --agents launch mode and branded icon.\n\nRefs #335321

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 9, 2026 18:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The task uses the existing launch path, and the packaged icon path and frames are valid.

Review tier: Balanced
Findings: None

What changed in this PR

Adds direct Agents Window access from the Windows taskbar jump list.

Changes:

  • Adds a localized Agents Window task using --agents.
  • Packages a validated multi-resolution Agents icon.
File Description
workspacesHistoryMainService.ts Registers the jump-list task.
gulpfile.vscode.ts Packages the icon on Windows.
resources/​win32/​agents.ico Provides the branded task icon.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Give the Windows taskbar button the same visual identity as the jump-list task.

Refs #335321

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the branded Agents icon for Agents Window entries while preserving existing file and workspace icons for other windows.

Fixes #315734

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dmitrivMS Dmitriy Vasyura (dmitrivMS) changed the title sessions: add Agents Window taskbar shortcut sessions: add Agents Window taskbar shortcut and icons Sep 10, 2026
Carry the authoritative Agents window flag into the window picker instead of comparing incompatible native and renderer workspace URI schemes. Reuse the distro-mixed sessions.ico path so native Windows icons match each product quality.

Fixes #315734

Refs #335321

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The Switch Window implementation introduces a prohibited dependency from vs/workbench onto the higher vs/sessions layer.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 Low severity

New issues introduced by this change (1)
Severity Finding
Low severity src/​vs/​workbench/​electron-browser/​actions/​windowActions.ts — This makes the lower vs/workbench layer resolve an asset owned by vs/sessions, contrary to the…

Comment thread src/vs/workbench/electron-browser/actions/windowActions.ts Outdated
Carry the BrowserWindow icon path through opened-window metadata so Switch Window can render it without depending on Sessions-owned assets.

Fixes #315734

Refs #315935 #335321

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Base: 0b2d79f0 Current: 4e2bd893

No screenshot changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The Windows integration, icon packaging, metadata propagation, and fallback behavior are consistent and complete.

Review tier: Balanced
Findings: None

Issues resolved since last review (1)
Severity Finding
Low severity src/​vs/​workbench/​electron-browser/​actions/​windowActions.ts — This makes the lower vs/workbench layer resolve an asset owned by vs/sessions, contrary to the… View resolved comment

Keep the internal Agents workspace in shared recent history while omitting it from the Windows jump list now that a dedicated task is available.

Refresh the CI-provided component fixture hashes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The shell integration, icon propagation, packaging, and fallback behavior are consistent and complete.

Review tier: Balanced
Findings: None

Comment thread src/vs/platform/windows/electron-main/windowImpl.ts Outdated
Expose native icon metadata only for the explicit Agents Window override so regular workspace, folder, and file entries continue using their resource icons.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dmitrivMS Dmitriy Vasyura (dmitrivMS) added the workbench-os-integration Native OS integration issues label Sep 10, 2026
@dmitrivMS Dmitriy Vasyura (dmitrivMS) changed the title sessions: add Agents Window taskbar shortcut and icons Add Agents Window taskbar shortcut and icons Sep 10, 2026
@dmitrivMS
Dmitriy Vasyura (dmitrivMS) marked this pull request as ready for review September 10, 2026 21:33
@dmitrivMS
Dmitriy Vasyura (dmitrivMS) merged commit 716e76d into main Sep 10, 2026
42 checks passed
@dmitrivMS
Dmitriy Vasyura (dmitrivMS) deleted the agents/add-agents-window-shortcut branch September 10, 2026 21:43
@vs-code-engineering vs-code-engineering Bot added this to the 1.138.0 milestone Sep 10, 2026
Dmitriy Vasyura (dmitrivMS) added a commit that referenced this pull request Sep 11, 2026
Revert "Add Agents Window taskbar shortcut and icons (#335333)"

This reverts commit 716e76d.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents-window windows VS Code on Windows issues workbench-os-integration Native OS integration issues

Projects

None yet

3 participants