Hold Services in Object instead of an Array #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mrcwbr
commented
Aug 8, 2023
mrcwbr
commented
- refactored the internal service variable to an object instead of an array
- removed the factory from the object after the instantiation
- removed code duplications
- updated several dev dependencies
… array - removed the factory from the object after the instantiation - removed code duplications - updated several dev dependencies
mrcwbr
force-pushed
the
feature/hold_services_in_object
branch
2 times, most recently
from
b294265
to
eaa6033
Compare
mrcwbr
force-pushed
the
feature/hold_services_in_object
branch
from
eaa6033
to
b3dd1b8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.