Drop extra slashes #866
Merged
Drop extra slashes #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the request unchanged if the target seems canonical, otherwise: * Turns repeated slashes into a single one * Drop the last slash * Redirect to the resulting target Note: Dream.split_targer bugged? When passed a string beginning with exactly two slashes, split_target drops everything before the first slash. See: aantron/dream#248 As a work around, three slashes are preprended to all targets
|
Dream issue may be upstream: mirage/ocaml-uri#167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the request unchanged if the target seems canonical, otherwise:
Issue: #820
Note: Is
Dream.split_targetbugged? When passed a string beginning with exactly two slashes,split_targetdrops everything before the third slash. See: aantron/dream#248 As a workaround; three slashes are prepended to all targets